Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the actual number of the rules used by the extension #78

Closed
ameshkov opened this issue Nov 21, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@ameshkov
Copy link
Member

commented Nov 21, 2015

Look at the screenshot:
http://screencast.com/t/yRWWzCTOgni

Text: Filter rules count: N

In case of Safari 9+ we should print there the actual number of converted rules, not the request filter size (as for other extensions)

If max rules count limit is hit we should show a top-line alert:
http://screencast.com/t/QhrRv9yxVKw

Text: Too many filters enabled. Safari cannot use more than 50000 rules.

@ameshkov ameshkov added this to the 2.1 milestone Nov 21, 2015

Mizzick added a commit that referenced this issue Dec 1, 2015

Mizzick added a commit that referenced this issue Dec 1, 2015

@Mizzick Mizzick closed this Dec 1, 2015

Mizzick added a commit that referenced this issue Dec 2, 2015

Mizzick added a commit that referenced this issue Dec 2, 2015

Mizzick added a commit that referenced this issue Dec 2, 2015

Mizzick added a commit that referenced this issue Dec 2, 2015

Mizzick added a commit that referenced this issue Dec 2, 2015

atropnikov added a commit that referenced this issue Dec 3, 2015

#78
Small fixes;

Mizzick added a commit that referenced this issue Dec 4, 2015

atropnikov added a commit that referenced this issue Dec 14, 2015

#78
fixes;

@Dariamag Dariamag changed the title Print the actual number of the rules used by the extension Display the actual number of the rules used by the extension Dec 24, 2015

Mizzick pushed a commit that referenced this issue Jan 19, 2018

Dmitry Kolyshev
Merge pull request #78 in EXTENSIONS/browser-extension from release/b…
…uild/2.8.5 to master

* commit 'a1a3d1f802588b0959d897f49401ec2d5241ca55':
  updated filters and version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.