Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $badfilter modifier support #866

Closed
ameshkov opened this issue Sep 29, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Sep 29, 2017

@ameshkov ameshkov added this to the 2.8 milestone Sep 29, 2017
@ameshkov ameshkov added the Enhancement label Oct 3, 2017
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Oct 3, 2017

I suppose, that we should have a separate "index" with the badfilter rules (with the badfilter modifier stripped from the collection).

Once you encounter a rule matching the $badfilter one, you should ignore it. This will allow adding or removing badfilter rules in real time without rebuilding the filter.

Mizzick added a commit that referenced this issue Nov 18, 2017
Mizzick added a commit that referenced this issue Nov 18, 2017
Mizzick added a commit that referenced this issue Nov 18, 2017
Mizzick added a commit that referenced this issue Nov 18, 2017
@Mizzick Mizzick closed this Nov 21, 2017
Mizzick pushed a commit that referenced this issue Nov 21, 2017
…ssues/866-bad-filter to master

* commit '3e4170fd18c03a3ede8839f6347a08442198bf43':
  #866 BadFilter rules modifier
  #866 BadFilter rules modifier
  #866 BadFilter rules modifier
  #866 BadFilter rules modifier
  #866 BadFilter rules modifier
  #866 BadFilter rules modifier safari converter
  #866 BadFilter rules modifier safari converter
  #866 BadFilter rules modifier
  #866 BadFilter rules modifier
  #866 BadFilter rules modifier
Mizzick added a commit that referenced this issue Nov 21, 2017
Mizzick added a commit that referenced this issue Nov 21, 2017
Mizzick added a commit that referenced this issue Nov 21, 2017
Mizzick added a commit that referenced this issue Nov 21, 2017
Mizzick added a commit that referenced this issue Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.