Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The issues with content filtering rules in Firefox #959

Closed
Alex-302 opened this issue Feb 20, 2018 · 5 comments
Closed

The issues with content filtering rules in Firefox #959

Alex-302 opened this issue Feb 20, 2018 · 5 comments
Assignees
Milestone

Comments

@Alex-302
Copy link
Member

@Alex-302 Alex-302 commented Feb 20, 2018

This rule breaks some styles
e.mail.ru$$script[tag-content="patron.radar("adblock_detect-by""][max-length="1000"]

Screenshot:

image

@ameshkov ameshkov added this to the 2.9 milestone Feb 20, 2018
@ameshkov ameshkov added the P2: High label Feb 20, 2018
@AdamWr

This comment has been minimized.

Copy link

@AdamWr AdamWr commented Feb 20, 2018

Another examples:
AdguardTeam/AdguardFilters#11892
speedtest.net$$div[class="dfp-ab-leaderboard"]
and
AdguardTeam/AdguardFilters#11394 (comment)
dcinside.com$$script[tag-content="function adBlockDetected()"]

@Mizzick

This comment has been minimized.

Copy link
Contributor

@Mizzick Mizzick commented Feb 28, 2018

I guess we cannot control it. If you are removing some elements from layout, there is no guarantees that the rest will stay on its place. I mean, it's the same situation as with element hiding rules, if you remove something, all the rest could be messed.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Mar 3, 2018

The point is that for some reason it works differently in the Win/Mac versions and in the FF extension.

I suppose we may be damaging HTML in FF, and we need to find out how exactly.

Here's what you need to do:

  1. Use this rule in AG for Win/Mac and in FF extension
  2. Compare the resulting output (I guess you'll need to log what you've got)
@Mizzick

This comment has been minimized.

Copy link
Contributor

@Mizzick Mizzick commented Mar 16, 2018

Okay, I got it finally!
Content edited page lost <DOCTYPE ..>

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Mar 19, 2018

That's serious indeed:)

atropnikov pushed a commit that referenced this issue Mar 29, 2018
atropnikov pushed a commit that referenced this issue Mar 29, 2018
atropnikov pushed a commit that referenced this issue Mar 29, 2018
…issues/959 to master

* commit '5510d4d7b6eff5c0d4c461a5d6bbff1390082ef5':
  Fix #959 content filtering doctype
  Fix #959 content filtering doctype
  Fix #959 content filtering doctype
@Mizzick Mizzick closed this in e3f6148 Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.