Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All previous fixes + Fix/moikolodets.ru #20099 #25739

Merged
merged 32 commits into from Nov 23, 2018
Merged

Conversation

slavaleleka
Copy link
Contributor

Description:

  • Current behaviour:
Screenshot:

image


  • Expected behaviour:
Screenshot:

image


Steps to reproduce the problem:

System configuration

Filters:

Information Value
Operating system: ?
Operating system version (Android/iOS) ?
Browser: ?
AdGuard version: ?
Filters enabled: ?
AdGuard mode (Android only): VPN / Proxy (manual/auto)
Filtering quality (Android only): High-quality / High-speed / Simplified
HTTPS filtering (Android only): On (Default/Blacklist mode) / Off
Simplified filters (iOS only) On / Off
AdGuard DNS: None / Default / Family Protection
Stealth mode options (Windows only) ?
Helpdesk ID (if exists): ?

@slavaleleka slavaleleka changed the title Fix/moikolodets.ru 20099 Fix/moikolodets.ru #20099 Nov 22, 2018
@slavaleleka slavaleleka reopened this Nov 22, 2018
@slavaleleka slavaleleka changed the title Fix/moikolodets.ru #20099 ALL PREVIOUS FIXES + Fix/moikolodets.ru #20099 Nov 22, 2018
@slavaleleka slavaleleka changed the title ALL PREVIOUS FIXES + Fix/moikolodets.ru #20099 All previous fixes + Fix/moikolodets.ru #20099 Nov 22, 2018
@@ -77,6 +77,11 @@ maxstock.co.il##.dsticky
business.ru##.slideBannerContainer
memepedia.ru##.spu-bg
memepedia.ru##.spu-box
! https://github.com/AdguardTeam/AdguardFilters/issues/25661
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ненужный коммент

@@ -77,6 +77,11 @@ maxstock.co.il##.dsticky
business.ru##.slideBannerContainer
memepedia.ru##.spu-bg
memepedia.ru##.spu-box
! https://github.com/AdguardTeam/AdguardFilters/issues/25661
emart.ssg.com###floatWrap3
! https://github.com/AdguardTeam/AdguardFilters/issues/25644
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ненужный коммент

! https://github.com/AdguardTeam/AdguardFilters/issues/19976
hotline.ua#$#body.reset-scroll:before { z-index: -9999!important; display: none!important; }
hotline.ua#$#body { overflow: visible!important; }
hotline.ua##.fade.active > .lightbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

если нужно разблокировать прокрутку, все элементы попапа должны быть убраны таким же типом правил. В данном случае - hotline.ua#$#.fade.active > .lightbox { display: none!important; }

! https://github.com/AdguardTeam/AdguardFilters/issues/25661
emart.ssg.com###floatWrap3
! https://github.com/AdguardTeam/AdguardFilters/issues/25644
plutonpromo.az###parent_popup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а зачем удалять правило?

@@ -1275,7 +1270,7 @@ mic.com#%#if (typeof localStorage != 'undefined' && localStorage.setItem) { loca
! https://github.com/AdguardTeam/AdguardFilters/issues/19976
hotline.ua#$#body.reset-scroll:before { z-index: -9999!important; display: none!important; }
hotline.ua#$#body { overflow: visible!important; }
hotline.ua##.fade.active > .lightbox
hotline.ua##.fade.active > .lightbox:has(> .lightbox-hd > p.h3:contains(Есть вопрос))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

здесь #$# должно быть, а не расширенный CSS, т.к. на ios прокрутка сломается

@@ -16,6 +16,8 @@ t-online.de##.Tvideosearch ~ #Tcontbox > #Tcontboxi > div[class]:not([id]):not([
t-online.de##div[data-dy-embedded-object]
vivud.com##.closeContainer
videam.party##.ads
galka.if.ua##.main-sidebar.right > .widget:has(> .textwidget, > h3:contains(Google +), > h3:contains(Поділись з друзями))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

да в основных фильтрах лучше скрывать. Только огрызок от рекламы и соц виджеты раздели

!
igrotop.com##.hideAds
photopea.com##.rightmost
trudbox.com.ua##.job-alert-modal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

на этом сайте остатки рекламы в резюме пропущены

nashaplaneta.net##.badv
magictemple.ru###custom_html-2
ukropnews.com##.banner
fast-tracker.co##noindex > center
kinoeffect.ru##article a[rel="nofollow"] > img
kinoeffect.ru##.bazuka
igrotop.com##.ads
! https://github.com/AdguardTeam/AdguardFilters/issues/25671
galka.if.ua##a[href="http://yarkovytsya.com.ua/proekti.html"]
galka.if.ua##.header-menu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

такими можно сломать. Более узкий селектор лучше сделай.

galka.if.ua##.header-menu
galka.if.ua##.header-addons

@@ -163,6 +164,11 @@ ba3a.net##div[align="center"] > table[width="100%"] > tbody > tr:has(> td.header
newdaynews.ru##body > div.page-main > div.bnd-scr:has(> div.bnd-cnt > h2.bnd-title > b:contains(Новости партнеров))
kinocoin.online#$#body:has(> div) { padding-top: 0!important; }
razlozhi.ru##body *:has(> [id*="R-A-"])
gidonline.in#$#.zbin.zrec {display: none !important;}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это не расширенный CSS.
{display: none !important;} лучше с пробелами возле скобок { display: none!important; }, одинаковые стили проще искать.

@@ -163,6 +164,11 @@ ba3a.net##div[align="center"] > table[width="100%"] > tbody > tr:has(> td.header
newdaynews.ru##body > div.page-main > div.bnd-scr:has(> div.bnd-cnt > h2.bnd-title > b:contains(Новости партнеров))
kinocoin.online#$#body:has(> div) { padding-top: 0!important; }
razlozhi.ru##body *:has(> [id*="R-A-"])
gidonline.in#$#.zbin.zrec {display: none !important;}
galka.if.ua##a[href="http://yarkovytsya.com.ua/proekti.html"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

неправильный файл

galka.if.ua##a[href="http://yarkovytsya.com.ua/proekti.html"]
galka.if.ua##.block > div > a#check_link
galka.if.ua##.wrapper > .header-addons

@@ -17,9 +17,7 @@ evvelcevap.com##.fancybox-overlay[class*="snp-pop-"]
godealla.pl##.facebook.playfair
godealla.pl##.overlay
iopen.pl###facebook
! https://github.com/AdguardTeam/AdguardFilters/issues/19656
w-o-s.ru###social-subscribe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

соц попапы надо ещё в раздражителях дублировать

@@ -78,6 +78,7 @@ hdplayer.org###player > .alert_msg
||webfilecloud.net/*/affbn/*.html
sinemapol.org##.diziay-fot
sinemapol.org##.advertise-468x60
coffee.digital###panel > .masthead-banner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно без #panel >, лишнее не скроет

@Alex-302 Alex-302 merged commit 5c17bc9 into master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants