New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VPN autopause disabled by default for newer devices #1000

Closed
ameshkov opened this Issue Dec 27, 2016 · 17 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented Dec 27, 2016

For Android 6.0 and newer we should make pref.vpn.disable.pause checked by default.

I've been testing it for quite some time and it seems to be working just ok.

@ameshkov ameshkov added this to the 2.9 milestone Dec 27, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Dec 31, 2016

Contributor

I've been using it this way on both my 4.4.2 & 7.0 for a long time & never experienced an issue from it, directly. The only thing I'd suggest is maybe a periodic cache flush - sometimes a bad DNS entry (I think) makes into the cache (mostly due to weak signal), & toggling AG's status resolves it.

Contributor

TPS commented Dec 31, 2016

I've been using it this way on both my 4.4.2 & 7.0 for a long time & never experienced an issue from it, directly. The only thing I'd suggest is maybe a periodic cache flush - sometimes a bad DNS entry (I think) makes into the cache (mostly due to weak signal), & toggling AG's status resolves it.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jan 16, 2017

Member

There're some issues with simply enabling pref.vpn.disable.pause.

For instance, it also controls auto pause in the case of tethering. I guess we should separate these things in two different low-level flags.

Also, it will mess with the app auto-restart when Android kills it.

And one more thing. VPN does not mess with Tethering in a case of Android 7.1. We should test it on other firmware though, Samsung for instance.

Member

ameshkov commented Jan 16, 2017

There're some issues with simply enabling pref.vpn.disable.pause.

For instance, it also controls auto pause in the case of tethering. I guess we should separate these things in two different low-level flags.

Also, it will mess with the app auto-restart when Android kills it.

And one more thing. VPN does not mess with Tethering in a case of Android 7.1. We should test it on other firmware though, Samsung for instance.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jan 17, 2017

Member

Also, we should apply complicated routes all the time in this case as we won't be able to re-setup the VPN routes without restarting it.

Member

ameshkov commented Jan 17, 2017

Also, we should apply complicated routes all the time in this case as we won't be able to re-setup the VPN routes without restarting it.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 14, 2017

Member

It appears, that for now the only devices we can do it for are Nexus and Pixel with Nougat.

Member

ameshkov commented Feb 14, 2017

It appears, that for now the only devices we can do it for are Nexus and Pixel with Nougat.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Feb 14, 2017

Contributor

It appears, that for now the only devices we can do it for are Nexus and Pixel with Nougat.

I've been doing this w/ non-GPhones regularly. Why'd you specify them?

Also, we should apply complicated routes all the time in this case as we won't be able to re-setup the VPN routes without restarting it.

I never turn on that Low-level Setting (except as a test a while ago & then turned it back off, as it seemed to cause problems similar to #737) & everything seems fine w/o it, even across multiple (wifi) networks, but I'll re-enable to try & see what effect it has, if you want me to?

Contributor

TPS commented Feb 14, 2017

It appears, that for now the only devices we can do it for are Nexus and Pixel with Nougat.

I've been doing this w/ non-GPhones regularly. Why'd you specify them?

Also, we should apply complicated routes all the time in this case as we won't be able to re-setup the VPN routes without restarting it.

I never turn on that Low-level Setting (except as a test a while ago & then turned it back off, as it seemed to cause problems similar to #737) & everything seems fine w/o it, even across multiple (wifi) networks, but I'll re-enable to try & see what effect it has, if you want me to?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 14, 2017

Member

I've been doing this w/ non-GPhones regularly. Why'd you specify them?

We disable auto-pause functionality if both of the following conditions are true:

  1. A device does not suffer from the tethering issue.
  2. A device does not suffer from power saving mode issue.

In both cases, we need to pause protection automatically.

For instance, Samsung with Nougat suffers from the tethering issue.

I never turn on that Low-level Setting (except as a test a while ago & then turned it back off, as it seemed to cause problems similar to #737)

Actually, using complicated routes is preferable. Filtering LAN addresses might cause issues with a lot of apps. That's why by default we are in fact using "complicated routes" except some rare cases with old Android versions/devices.

Member

ameshkov commented Feb 14, 2017

I've been doing this w/ non-GPhones regularly. Why'd you specify them?

We disable auto-pause functionality if both of the following conditions are true:

  1. A device does not suffer from the tethering issue.
  2. A device does not suffer from power saving mode issue.

In both cases, we need to pause protection automatically.

For instance, Samsung with Nougat suffers from the tethering issue.

I never turn on that Low-level Setting (except as a test a while ago & then turned it back off, as it seemed to cause problems similar to #737)

Actually, using complicated routes is preferable. Filtering LAN addresses might cause issues with a lot of apps. That's why by default we are in fact using "complicated routes" except some rare cases with old Android versions/devices.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 14, 2017

Member

Auto-pause disabled by default for new Nexus and Pixel devices. Also, there are some improvements that will help it function properly if a user opts to disable it manually.

Member

ameshkov commented Feb 14, 2017

Auto-pause disabled by default for new Nexus and Pixel devices. Also, there are some improvements that will help it function properly if a user opts to disable it manually.

@ameshkov ameshkov closed this Feb 14, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 21, 2017

Member

@vozersky we need to re-test Samsung tethering issue with pref.vpn.ipv4.complex enabled

Member

ameshkov commented Feb 21, 2017

@vozersky we need to re-test Samsung tethering issue with pref.vpn.ipv4.complex enabled

@ameshkov ameshkov reopened this Feb 21, 2017

@ameshkov ameshkov closed this Mar 2, 2017

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Mar 2, 2017

Member

@ameshkov
with disabled pause and pref.vpn.ipv4.complex enabled there is still no internet connection in the mobile hotspot network on galaxy s7

Member

vozersky commented Mar 2, 2017

@ameshkov
with disabled pause and pref.vpn.ipv4.complex enabled there is still no internet connection in the mobile hotspot network on galaxy s7

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Mar 2, 2017

Member

Looks like the issue is gone with the latest update of Samsung firmware.
I've just updated S7 to G930FXXU1DQB7 and tethering works now.

  • Galaxy S7 Firmware: G930FXXU1DQB7/G930FOXE1DQB1/G930FXXU1DQB3
  • Adguard 2.9 Beta
Member

vozersky commented Mar 2, 2017

Looks like the issue is gone with the latest update of Samsung firmware.
I've just updated S7 to G930FXXU1DQB7 and tethering works now.

  • Galaxy S7 Firmware: G930FXXU1DQB7/G930FOXE1DQB1/G930FXXU1DQB3
  • Adguard 2.9 Beta
@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 2, 2017

Member

Firmware version?

Member

ameshkov commented Mar 2, 2017

Firmware version?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 2, 2017

Member

@vozersky check OnePlus as well

Member

ameshkov commented Mar 2, 2017

@vozersky check OnePlus as well

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 2, 2017

Member

Let's reopen this issue then.

Member

ameshkov commented Mar 2, 2017

Let's reopen this issue then.

@ameshkov ameshkov reopened this Mar 2, 2017

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Mar 3, 2017

Member

Tethering also works fine on OnePlus 3.

Member

vozersky commented Mar 3, 2017

Tethering also works fine on OnePlus 3.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 3, 2017

Member

What about power saving? No issues?

Member

ameshkov commented Mar 3, 2017

What about power saving? No issues?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 3, 2017

Member

Ok then, let's do it for all devices with Nougat.

Member

ameshkov commented Mar 3, 2017

Ok then, let's do it for all devices with Nougat.

@ameshkov ameshkov closed this Mar 3, 2017

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Mar 3, 2017

Member

Yeah, didn't find any power saving issues on galaxy s7 (mid powersaving mode)

Member

vozersky commented Mar 3, 2017

Yeah, didn't find any power saving issues on galaxy s7 (mid powersaving mode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment