New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while updating Adguard #1086

Closed
ameshkov opened this Issue Mar 3, 2017 · 20 comments

Comments

Projects
None yet
5 participants
@ameshkov
Member

ameshkov commented Mar 3, 2017

Thread: Thread[main,5,main]; Uncaught exception:

java.lang.RuntimeException: Error receiving broadcast Intent { act=android.intent.action.DOWNLOAD_COMPLETE flg=0x10 pkg=com.adguard.android (has extras) } in com.adguard.android.service.am@40d6306
	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:891) ~[na:0.0]
	at android.os.Handler.handleCallback(Handler.java:739) ~[na:0.0]
	at android.os.Handler.dispatchMessage(Handler.java:95) ~[na:0.0]
	at android.os.Looper.loop(Looper.java:148) ~[na:0.0]
	at android.app.ActivityThread.main(ActivityThread.java:5437) ~[na:0.0]
	at java.lang.reflect.Method.invoke(Native Method) ~[na:0.0]
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) ~[na:0.0]
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616) ~[na:0.0]
	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:102) ~[na:na]
Caused by: java.lang.SecurityException: Permission Denial: reading com.android.providers.downloads.DownloadProvider uri content://downloads/all_downloads/95 from pid=28288, uid=10112 requires android.permission.ACCESS_ALL_DOWNLOADS, or grantUriPermission()
	at android.os.Parcel.readException(Parcel.java:1620) ~[na:0.0]
	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:183) ~[na:0.0]
	at android.database.DatabaseUtils.readExceptionWithFileNotFoundExceptionFromParcel(DatabaseUtils.java:146) ~[na:0.0]
	at android.content.ContentProviderProxy.openTypedAssetFile(ContentProviderNative.java:692) ~[na:0.0]
	at android.content.ContentResolver.openTypedAssetFileDescriptor(ContentResolver.java:1107) ~[na:0.0]
	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:944) ~[na:0.0]
	at android.content.ContentResolver.openFileDescriptor(ContentResolver.java:797) ~[na:0.0]
	at android.content.ContentResolver.openFileDescriptor(ContentResolver.java:751) ~[na:0.0]
	at android.app.DownloadManager.openDownloadedFile(DownloadManager.java:1010) ~[na:0.0]
	at com.adguard.android.service.am.onReceive(Unknown Source) ~[na:0.0]
	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:881) ~[na:0.0]
	... 8 common frames omitted

@ameshkov ameshkov added the Bug label Mar 3, 2017

@ameshkov ameshkov added this to the 2.9 milestone Mar 3, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 3, 2017

Member

At least we should catch it

Member

ameshkov commented Mar 3, 2017

At least we should catch it

@ameshkov ameshkov changed the title from Crash while updating due to XPosed module to Crash while updating Adguard Mar 3, 2017

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Mar 6, 2017

Member

Changing permission string from <uses-permission android:name="android.permission.ACCESS_ALL_DOWNLOADS"/> to <uses-permission android:maxSdkVersion="21" android:name="android.permission.ACCESS_ALL_DOWNLOADS"/> Eliminates the string Not granting permission android.permission.ACCESS_ALL_DOWNLOADS to package com.adguard.android (protectionLevel=2 flags=0x3818be46) from the logs while updating/installing Adguard.
Simply put, we are telling Android that this permission is used like on the old version of OS :)

Member

Revertron commented Mar 6, 2017

Changing permission string from <uses-permission android:name="android.permission.ACCESS_ALL_DOWNLOADS"/> to <uses-permission android:maxSdkVersion="21" android:name="android.permission.ACCESS_ALL_DOWNLOADS"/> Eliminates the string Not granting permission android.permission.ACCESS_ALL_DOWNLOADS to package com.adguard.android (protectionLevel=2 flags=0x3818be46) from the logs while updating/installing Adguard.
Simply put, we are telling Android that this permission is used like on the old version of OS :)

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 9, 2017

Contributor

I don't know if this is same crash, but I just filed bug report (UserID should still be 1122984, I think) for today's update via Amazon Appstore:
screenshot_20170309-133956 01

Contributor

TPS commented Mar 9, 2017

I don't know if this is same crash, but I just filed bug report (UserID should still be 1122984, I think) for today's update via Amazon Appstore:
screenshot_20170309-133956 01

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 9, 2017

Member

More likely to be an issue with downloaded file, it might be corrupted. Does it help to tap update second time?

Member

ameshkov commented Mar 9, 2017

More likely to be an issue with downloaded file, it might be corrupted. Does it help to tap update second time?

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 9, 2017

Contributor

The app downloaded & installed fine, but, when running it gives this sometimes & crashes. Are you asking me to uninstall & redownload?

Contributor

TPS commented Mar 9, 2017

The app downloaded & installed fine, but, when running it gives this sometimes & crashes. Are you asking me to uninstall & redownload?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 9, 2017

Member

Wow, I then have no idea what's going on, really:)

Member

ameshkov commented Mar 9, 2017

Wow, I then have no idea what's going on, really:)

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 9, 2017

Member

I wonder could it be damaged somehow with the amazon DRM?

Member

ameshkov commented Mar 9, 2017

I wonder could it be damaged somehow with the amazon DRM?

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 9, 2017

Contributor

Does my bug report help @ all?

Contributor

TPS commented Mar 9, 2017

Does my bug report help @ all?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 9, 2017

Member

I am pretty sure it should be filed as a separate bug report. But only if it is reproducible:)

Member

ameshkov commented Mar 9, 2017

I am pretty sure it should be filed as a separate bug report. But only if it is reproducible:)

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 9, 2017

Contributor

Well, I've had it happen 2× in 10 minutes, but I've no idea how I did it. I'll play w/ it & see.

Contributor

TPS commented Mar 9, 2017

Well, I've had it happen 2× in 10 minutes, but I've no idea how I did it. I'll play w/ it & see.

@Bohdan-SUP

This comment has been minimized.

Show comment
Hide comment
@Bohdan-SUP

Bohdan-SUP Mar 9, 2017

The log, just in case -
debug (2).txt

Bohdan-SUP commented Mar 9, 2017

The log, just in case -
debug (2).txt

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 9, 2017

Contributor

@Bohdan-SUP Thanks!

@ameshkov Well, this isn't a Kindle nor any other kind of Amazon device, & my wifi's been solid, so it doesn't seem to apply. 🤷

Contributor

TPS commented Mar 9, 2017

@Bohdan-SUP Thanks!

@ameshkov Well, this isn't a Kindle nor any other kind of Amazon device, & my wifi's been solid, so it doesn't seem to apply. 🤷

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 10, 2017

Member

Done

Member

ameshkov commented Mar 10, 2017

Done

@ameshkov ameshkov closed this Mar 10, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 24, 2017

Member

Guys, let's add ACCESS_ALL_DOWNLOADS after all, there are more reports on this issue

Member

ameshkov commented Mar 24, 2017

Guys, let's add ACCESS_ALL_DOWNLOADS after all, there are more reports on this issue

@ameshkov ameshkov reopened this Mar 24, 2017

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 27, 2017

Contributor

Further update from my side (sorry for not reporting earlier): Had same problem w/ last ß update, too. Killing app & clearing app cache might have fixed it, but it definitely worked after reboot. ☺

Contributor

TPS commented Mar 27, 2017

Further update from my side (sorry for not reporting earlier): Had same problem w/ last ß update, too. Killing app & clearing app cache might have fixed it, but it definitely worked after reboot. ☺

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 27, 2017

Member

@TPS something is really not okay with Amazon DRM:)

Member

ameshkov commented Mar 27, 2017

@TPS something is really not okay with Amazon DRM:)

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Mar 28, 2017

Member

Fixed.

Member

Revertron commented Mar 28, 2017

Fixed.

@Revertron Revertron closed this Mar 28, 2017

@nkartyshov

This comment has been minimized.

Show comment
Hide comment
@nkartyshov

nkartyshov Jun 30, 2017

Member

I tried update AG with 2.9.111 to current version and app crash with exception:

android.os.FileUriExposedException: file:///storage/emulated/0/Android/data/com.adguard.android/cache/adguard.apk exposed beyond app through Intent.getData()

Member

nkartyshov commented Jun 30, 2017

I tried update AG with 2.9.111 to current version and app crash with exception:

android.os.FileUriExposedException: file:///storage/emulated/0/Android/data/com.adguard.android/cache/adguard.apk exposed beyond app through Intent.getData()

@nkartyshov nkartyshov reopened this Jun 30, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jun 30, 2017

Member

@nkartyshov exception text is a bit different from this issue, let's file a new bug report instead.

Member

ameshkov commented Jun 30, 2017

@nkartyshov exception text is a bit different from this issue, let's file a new bug report instead.

@ameshkov ameshkov closed this Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment