New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App details activity is very slow now #1099

Closed
ameshkov opened this Issue Mar 12, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ameshkov
Member

ameshkov commented Mar 12, 2017

@ameshkov ameshkov added the UI label Mar 12, 2017

@ameshkov ameshkov added this to the 2.9 milestone Mar 12, 2017

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Mar 13, 2017

Member

I'm unable to see this on my device, but I've run method tracing.
It shows, that we run too much of getDefaultRules() - it can be cached without consequences (and it has an impact on SettingsFirewallFragment, when going back from FirewallPackageFragment), and httpsFilteringService.isCaCertificateInstalled() - it can be the main problem in FirewallPackageFragment. The checking of all installed certificates is CPU expensive...

Member

Revertron commented Mar 13, 2017

I'm unable to see this on my device, but I've run method tracing.
It shows, that we run too much of getDefaultRules() - it can be cached without consequences (and it has an impact on SettingsFirewallFragment, when going back from FirewallPackageFragment), and httpsFilteringService.isCaCertificateInstalled() - it can be the main problem in FirewallPackageFragment. The checking of all installed certificates is CPU expensive...

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Mar 13, 2017

Member

isCaCertificateInstalled() - speed up by x7,5.
getDefaultRules() - cached, will be much faster now.

Member

Revertron commented Mar 13, 2017

isCaCertificateInstalled() - speed up by x7,5.
getDefaultRules() - cached, will be much faster now.

@Revertron Revertron closed this Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment