New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use locale-specific number format on the main screen #1117

Closed
Eugene-Savenko opened this Issue Mar 21, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@Eugene-Savenko
Member

Eugene-Savenko commented Mar 21, 2017

It would be better to have it like 364.500 rather than how it's now:

image

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 22, 2017

Contributor

Umm, be quite careful with this: different languages/dialects/regions use very different schemes for # division. Please use Android's own NumberFormat or equivalent (instead of making your own) in all # fields throughout UI.

Contributor

TPS commented Mar 22, 2017

Umm, be quite careful with this: different languages/dialects/regions use very different schemes for # division. Please use Android's own NumberFormat or equivalent (instead of making your own) in all # fields throughout UI.

@ameshkov ameshkov added this to the 2.9 milestone Mar 22, 2017

@ameshkov ameshkov self-assigned this Mar 22, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 22, 2017

Member

Yeah, we use it already except the main view:)

Member

ameshkov commented Mar 22, 2017

Yeah, we use it already except the main view:)

@ameshkov ameshkov changed the title from Use commas or other separators when showing blocked ad requests stats to Use locale-specific number format on the main screen Mar 22, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 22, 2017

Member

Done

Member

ameshkov commented Mar 22, 2017

Done

@ameshkov ameshkov closed this Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment