New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon license check hangs while doing the background check #1121

Closed
ameshkov opened this Issue Mar 22, 2017 · 20 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented Mar 22, 2017

That's what was causing filters update issues:
#999

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 22, 2017

Contributor

It checks license every filterlist update? Why?

Contributor

TPS commented Mar 22, 2017

It checks license every filterlist update? Why?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 22, 2017

Member

We use the same thread for all background update checks, and that thread was blocked by amazon license check.

Member

ameshkov commented Mar 22, 2017

We use the same thread for all background update checks, and that thread was blocked by amazon license check.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 22, 2017

Contributor

Oh, yeah, that reminds me: The 🔑 License Status > Manage Your Licenses menu option pull up licenses only for AG-site version, not the Amazon subscription, though using Amazon version. I'm actually not sure how to check on Amazon subscription from AG UI anymore, though I can obviously check via the Amazon apps or site directly.

Contributor

TPS commented Mar 22, 2017

Oh, yeah, that reminds me: The 🔑 License Status > Manage Your Licenses menu option pull up licenses only for AG-site version, not the Amazon subscription, though using Amazon version. I'm actually not sure how to check on Amazon subscription from AG UI anymore, though I can obviously check via the Amazon apps or site directly.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Mar 22, 2017

Member

Fixed, review AJC-CR-201

Member

Revertron commented Mar 22, 2017

Fixed, review AJC-CR-201

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Mar 22, 2017

Member

Test build is here: https://www.dropbox.com/s/jyfjjlbcnajqk3i/adguard-fix1121.apk?dl=1
Please, @TPS, test it thoroughly :)

Member

Revertron commented Mar 22, 2017

Test build is here: https://www.dropbox.com/s/jyfjjlbcnajqk3i/adguard-fix1121.apk?dl=1
Please, @TPS, test it thoroughly :)

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 22, 2017

Member

What I am concerned about is Amazon license check and refresh process.

Member

ameshkov commented Mar 22, 2017

What I am concerned about is Amazon license check and refresh process.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 23, 2017

Contributor

@Revertron Please, can you publish through Amazon ß? The build isn't upgrade compatible, & there's no method to export User Filters, which I don't want to lose.

Contributor

TPS commented Mar 23, 2017

@Revertron Please, can you publish through Amazon ß? The build isn't upgrade compatible, & there's no method to export User Filters, which I don't want to lose.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Mar 23, 2017

Member

Hm, okay, we will release RC today.

Member

Revertron commented Mar 23, 2017

Hm, okay, we will release RC today.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 26, 2017

Contributor

So, this works sufficiently for Nougat/7.1.1, but not Kitkat/4.4.2. Bug reports for each OS sent under user 1122984.

Contributor

TPS commented Mar 26, 2017

So, this works sufficiently for Nougat/7.1.1, but not Kitkat/4.4.2. Bug reports for each OS sent under user 1122984.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 26, 2017

Contributor

Nevermind, I just had 10 filters manual update on Nougat/7.1.1, so I don't think this fix solves #999 entirely; report resent.

Contributor

TPS commented Mar 26, 2017

Nevermind, I just had 10 filters manual update on Nougat/7.1.1, so I don't think this fix solves #999 entirely; report resent.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 27, 2017

Member

@Revertron are you sure the fix was merged? I see the very same stack trace there in the log, it is simply not possible with the fix:

Thread:	290	pool-1-thread-1	WAITING
-2 java.lang.Object.wait(Native Method)
2127 java.lang.Thread.parkFor$(Thread.java:2127)
325 sun.misc.Unsafe.park(Unsafe.java:325)
161 java.util.concurrent.locks.LockSupport.park(LockSupport.java:161)
840 java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:840)
994 java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:994)
1303 java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1303)
203 java.util.concurrent.CountDownLatch.await(CountDownLatch.java:203)
-1 com.adguard.android.service.license.f.i(Unknown Source)
-1 com.adguard.android.service.license.f.g(Unknown Source)
-1 com.adguard.android.service.license.f$1.run(Unknown Source)
-1 com.adguard.android.service.t.run(Unknown Source)
428 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:428)
278 java.util.concurrent.FutureTask.runAndReset(FutureTask.java:278)
273 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:273)
1133 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
607 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
761 java.lang.Thread.run(Thread.java:761)
Member

ameshkov commented Mar 27, 2017

@Revertron are you sure the fix was merged? I see the very same stack trace there in the log, it is simply not possible with the fix:

Thread:	290	pool-1-thread-1	WAITING
-2 java.lang.Object.wait(Native Method)
2127 java.lang.Thread.parkFor$(Thread.java:2127)
325 sun.misc.Unsafe.park(Unsafe.java:325)
161 java.util.concurrent.locks.LockSupport.park(LockSupport.java:161)
840 java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:840)
994 java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:994)
1303 java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1303)
203 java.util.concurrent.CountDownLatch.await(CountDownLatch.java:203)
-1 com.adguard.android.service.license.f.i(Unknown Source)
-1 com.adguard.android.service.license.f.g(Unknown Source)
-1 com.adguard.android.service.license.f$1.run(Unknown Source)
-1 com.adguard.android.service.t.run(Unknown Source)
428 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:428)
278 java.util.concurrent.FutureTask.runAndReset(FutureTask.java:278)
273 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:273)
1133 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
607 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
761 java.lang.Thread.run(Thread.java:761)
@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 27, 2017

Member

@TPS could you please restart AG, wait for 10 minutes and send us a new log?

I'd like to check what's going on with the amazon subscription check.

Member

ameshkov commented Mar 27, 2017

@TPS could you please restart AG, wait for 10 minutes and send us a new log?

I'd like to check what's going on with the amazon subscription check.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 28, 2017

Contributor

@ameshkov Just sent.

Contributor

TPS commented Mar 28, 2017

@ameshkov Just sent.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Mar 28, 2017

Member

Fixed.

Member

Revertron commented Mar 28, 2017

Fixed.

@Revertron Revertron closed this Mar 28, 2017

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 28, 2017

Contributor

If you push another Amazon ß, I'll be happy to test this. 🙇

Contributor

TPS commented Mar 28, 2017

If you push another Amazon ß, I'll be happy to test this. 🙇

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Mar 29, 2017

Contributor

Sent another report via today's ß, but same negative result, & additional problem of licensing issue (my ß license wasn't active in-app on update, & was only activated w/ difficulty).

Contributor

TPS commented Mar 29, 2017

Sent another report via today's ß, but same negative result, & additional problem of licensing issue (my ß license wasn't active in-app on update, & was only activated w/ difficulty).

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Apr 2, 2017

Member

@TPS what with 2.9.60? It should've been better now.

I still don't understand why in your case license check is so unstable, but at least it shouldn't cause licensing issues now.

Member

ameshkov commented Apr 2, 2017

@TPS what with 2.9.60? It should've been better now.

I still don't understand why in your case license check is so unstable, but at least it shouldn't cause licensing issues now.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Apr 2, 2017

Contributor

It's noticeably better (@ least on Nougat/7.1.1ß, I think), but I'll keep an eye on it, & send a report soon if it seems off.

Contributor

TPS commented Apr 2, 2017

It's noticeably better (@ least on Nougat/7.1.1ß, I think), but I'll keep an eye on it, & send a report soon if it seems off.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Apr 4, 2017

Contributor

This works well. Thanks a bunch! 😁👏

Contributor

TPS commented Apr 4, 2017

This works well. Thanks a bunch! 😁👏

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Apr 4, 2017

Member

Okay, thank you for the test!

Member

Revertron commented Apr 4, 2017

Okay, thank you for the test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment