Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rework the user filter #1279
This all started here:
However, I am not happy with how it works at the moment, so let's rework it properly.
Empty user filter
New Rule dialog
User filter rules list view
Here are the rules for syntax highlighting:
Edit rule dialog
It is almost the same as the "New Rule" save for one more option -- "Delete".
User filter edit mode
Choosing "Edit filter" in the context menu leads a user to the "user filter edit mode".
Here is how it looks like:
Basically, this is just a huge multiline text input with "monospace" font and two options in the context menu:
This was referenced
Jun 13, 2017
Pls retain the rules order when ex-/importing (unlike today: https://forum.adguard.com/index.php?threads/bug-user-filter-import-puts-rules-in-random-order.22561/)
It will be simply too much for this task. I mean just look at how many different modifiers are out there:
It should be filed as a separate feature request for sure.
Does "User filter edit mode" already cover it?
referenced this issue
Jun 14, 2017
Reworked user filter:
@vozersky I need you to test it very thoroughly.
What to check:
Same for the whitelist.
NOTE: Don't forget to check that the changes are actually applied to filtering.
@Revertron the only issue I am aware of at the moment is the problem with action bar icons when search starts: https://monosnap.com/file/gC3u7EXFE4OpnjhcOxO4drcKl3Yo7W
everything works correctly except point 5: Import from an invalid file