New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a low-level setting to override system DNS #139

Closed
ameshkov opened this Issue Oct 26, 2015 · 18 comments

Comments

Projects
None yet
4 participants
@ameshkov
Member

ameshkov commented Oct 26, 2015

Name: pref.vpn.dns
Default value: empty
Allows to set a number of DNS servers (separated by a coma).

@ameshkov ameshkov added this to the 2.3 milestone Oct 26, 2015

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Oct 28, 2015

Contributor

Yes, please! Can this (hopefully) be extended to proxy, also? & is this a further detail to #117?

Contributor

TPS commented Oct 28, 2015

Yes, please! Can this (hopefully) be extended to proxy, also? & is this a further detail to #117?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 29, 2015

Member

Ops, it looks like the #117 is a duplicate now, I'll close it.

Member

ameshkov commented Oct 29, 2015

Ops, it looks like the #117 is a duplicate now, I'll close it.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 29, 2015

Member

Can this (hopefully) be extended to proxy, also?

Nah, upstream proxy is a bit different thing. It's good that you've reminded me about it. With low-level settings section it is rather and fast simple to add it as we don't need to spend time on messing with UI:)

Member

ameshkov commented Oct 29, 2015

Can this (hopefully) be extended to proxy, also?

Nah, upstream proxy is a bit different thing. It's good that you've reminded me about it. With low-level settings section it is rather and fast simple to add it as we don't need to spend time on messing with UI:)

@ameshkov ameshkov modified the milestones: 2.5, 2.3, 2.6 Nov 3, 2015

@vbagirov

This comment has been minimized.

Show comment
Hide comment
@vbagirov

vbagirov Nov 9, 2015

Member

Relevant ticket: CJW-173-81900

Adguard doesn't work with a particular WiFi network, unless DNS filtering is enabled manually.
'About phone' screenshots:
http://screencast.com/t/XFSDTBoScR
http://screencast.com/t/XFSDTBoScR

Member

vbagirov commented Nov 9, 2015

Relevant ticket: CJW-173-81900

Adguard doesn't work with a particular WiFi network, unless DNS filtering is enabled manually.
'About phone' screenshots:
http://screencast.com/t/XFSDTBoScR
http://screencast.com/t/XFSDTBoScR

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Nov 9, 2015

Member

@vbagirov looks like a different issue to me. Please file a new bug report.

Member

ameshkov commented Nov 9, 2015

@vbagirov looks like a different issue to me. Please file a new bug report.

@vbagirov

This comment has been minimized.

Show comment
Hide comment
@vbagirov

vbagirov Nov 10, 2015

Member

@ameshkov new bug report is filed: #174

Member

vbagirov commented Nov 10, 2015

@ameshkov new bug report is filed: #174

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS May 1, 2016

Contributor

Nah, upstream proxy is a bit different thing

@ameshkov I just re-read that, & realized I was possibly misunderstood. I think you thought I was referring to #51, but what I actually meant that, since the name of the option is pref.vpn.dns, it seems likely it's a VPN-only option.… Will it possible to use with AG proxy-mode, for those who don't/can't use VPN?

Also, will we able to setup separate IPv4 _&_ IPv6 DNS servers?

Contributor

TPS commented May 1, 2016

Nah, upstream proxy is a bit different thing

@ameshkov I just re-read that, & realized I was possibly misunderstood. I think you thought I was referring to #51, but what I actually meant that, since the name of the option is pref.vpn.dns, it seems likely it's a VPN-only option.… Will it possible to use with AG proxy-mode, for those who don't/can't use VPN?

Also, will we able to setup separate IPv4 _&_ IPv6 DNS servers?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 4, 2016

Member

Will it possible to use with AG proxy-mode, for those who don't/can't use VPN?

No, there's no easy way to do it in proxy mode.

Also, will we able to setup separate IPv4 & IPv6 DNS servers?

Why could you possible need this?

Member

ameshkov commented May 4, 2016

Will it possible to use with AG proxy-mode, for those who don't/can't use VPN?

No, there's no easy way to do it in proxy mode.

Also, will we able to setup separate IPv4 & IPv6 DNS servers?

Why could you possible need this?

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS May 4, 2016

Contributor

In the Windows systems I'm used to, IPv4 & IPv6 DNS are setup separately, &, if 1 is left out, it defaults to the connection's default for that protocol — it won't attempt to route the request to the otherwise-configured DNS server. Is this not the same under Android?

Contributor

TPS commented May 4, 2016

In the Windows systems I'm used to, IPv4 & IPv6 DNS are setup separately, &, if 1 is left out, it defaults to the connection's default for that protocol — it won't attempt to route the request to the otherwise-configured DNS server. Is this not the same under Android?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 4, 2016

Member

But that's not IPv4/v6 DNS, it is just primary and secondary DNS server. AG should also allow to set a list of DNS servers.

Member

ameshkov commented May 4, 2016

But that's not IPv4/v6 DNS, it is just primary and secondary DNS server. AG should also allow to set a list of DNS servers.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS May 5, 2016

Contributor

In Windows, IPv4 & IPv6 each have separate configuration with an arbitrary number (not just primary & secondary) of DNS servers. Typically, shouldn't AG need to be told which DNS servers can handle IPv4 or IPv6? Or will any requests be sent to each server in the list until an answer received?

Contributor

TPS commented May 5, 2016

In Windows, IPv4 & IPv6 each have separate configuration with an arbitrary number (not just primary & secondary) of DNS servers. Typically, shouldn't AG need to be told which DNS servers can handle IPv4 or IPv6? Or will any requests be sent to each server in the list until an answer received?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 5, 2016

Member

Typically, shouldn't AG need to be told which DNS servers can handle IPv4 or IPv6?

You don't know which address the host has.It is DNS server who tells you:)

Member

ameshkov commented May 5, 2016

Typically, shouldn't AG need to be told which DNS servers can handle IPv4 or IPv6?

You don't know which address the host has.It is DNS server who tells you:)

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS May 5, 2016

Contributor

💡 So, it's all unified in Android! NM, then, except, that we'll be able to provide either/both IPv4 & IPv6 addresses for this pref?

Contributor

TPS commented May 5, 2016

💡 So, it's all unified in Android! NM, then, except, that we'll be able to provide either/both IPv4 & IPv6 addresses for this pref?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 6, 2016

Member

So, it's all unified in Android!

No, why, it is unified everywhere. I guess in Windows they've divided settings into IPv4&IPv6 for some UX purposes. In our case it just won't be separated.

Member

ameshkov commented May 6, 2016

So, it's all unified in Android!

No, why, it is unified everywhere. I guess in Windows they've divided settings into IPv4&IPv6 for some UX purposes. In our case it just won't be separated.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS May 7, 2016

Contributor

In Windows, apparently, there's been separate IPv4 & IPv6 stacks (enabled/installed individually, even), each with their own settings, which DNS falls under.

Contributor

TPS commented May 7, 2016

In Windows, apparently, there's been separate IPv4 & IPv6 stacks (enabled/installed individually, even), each with their own settings, which DNS falls under.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS May 7, 2016

Contributor

It is DNS server who tells you:)

I suppose that's true for AG, because you all may have coded it that way, but I think the complete answer is a bit more involved. I understood it to be more like explained @ https://superuser.com/questions/403716/how-do-client-applications-know-to-use-ipv4-or-ipv6 so does the underlying Android OS influence this in anyway?

Contributor

TPS commented May 7, 2016

It is DNS server who tells you:)

I suppose that's true for AG, because you all may have coded it that way, but I think the complete answer is a bit more involved. I understood it to be more like explained @ https://superuser.com/questions/403716/how-do-client-applications-know-to-use-ipv4-or-ipv6 so does the underlying Android OS influence this in anyway?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 9, 2016

Member

@TPS

I understood it to be more like explained

The explanation is the same: OS does a DNS request, requesting both A and AAAA records and depending on the response it uses either IPv4 or IPv6. It does not depend on the DNS host address.

Member

ameshkov commented May 9, 2016

@TPS

I understood it to be more like explained

The explanation is the same: OS does a DNS request, requesting both A and AAAA records and depending on the response it uses either IPv4 or IPv6. It does not depend on the DNS host address.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron May 18, 2016

Member

I made it!
Set DNS line by line, as other lists.

Member

Revertron commented May 18, 2016

I made it!
Set DNS line by line, as other lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment