Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When HAR, pcap or "record everything" log level is enabled - show a permanent notification #1450

Closed
zovihuxij opened this issue Sep 17, 2017 · 10 comments
Assignees
Milestone

Comments

@zovihuxij
Copy link

@zovihuxij zovihuxij commented Sep 17, 2017

При включении журнала фильтрации не плохо было бы выводить какое-то дополнительное уведомление в строке состояния / шторке о том что это функция включена. А то иной раз забываю его выключить, и он остаётся включенным не один день.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Sep 17, 2017

Ну я кстати его вообще постоянно держу включенным

@ameshkov ameshkov added the Question label Sep 17, 2017
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Sep 17, 2017

Мы там предупреждаем, что он память/cpu жрет, но это мы от греха немножк преувеличиваем:) На деле это небольшая проблема.

@Alex-302

This comment has been minimized.

Copy link
Member

@Alex-302 Alex-302 commented Sep 17, 2017

дополнительное уведомление в строке состояния

про полный лог и HAR тоже не помешало бы

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Sep 17, 2017

Ну вот полный лог и HAR это да, могут диск забить и плохо влияют на производительность

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Sep 17, 2017

И pcap еще

@zovihuxij

This comment has been minimized.

Copy link
Author

@zovihuxij zovihuxij commented Sep 17, 2017

Ну лишним не будет, для меня было бы полезно, если бы выводилось уведомление на подобии как выводится при включение вышестоящего прокси.

@ameshkov ameshkov added this to the 3.0 milestone Sep 17, 2017
@ameshkov ameshkov added Feature request and removed Question labels Sep 17, 2017
@ameshkov ameshkov changed the title Журнал фильтрации When HAR or pcap is enabled - show permanent notification Sep 17, 2017
@ameshkov ameshkov added the P4: Low label Dec 4, 2017
@ameshkov ameshkov modified the milestones: 3.0, 2.12 May 28, 2018
@ameshkov ameshkov changed the title When HAR or pcap is enabled - show permanent notification When HAR, pcap or "record everything" log level is enabled - show a permanent notification May 28, 2018
@ameshkov ameshkov added P2: High and removed P4: Low labels May 28, 2018
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented May 28, 2018

@nkartyshov given that the TRACE-level logging level of CoreLibs is quite slow, we'd better do it in v2.12.

The notification text:
AdGuard might be working slow as one of the following features are enabled: full logging, capturing HAR or PCAP.

Buttons: Disable

Tapping on the button disables all three features.

@nkartyshov

This comment has been minimized.

Copy link
Contributor

@nkartyshov nkartyshov commented Jun 19, 2018

done

@nkartyshov

This comment has been minimized.

Copy link
Contributor

@nkartyshov nkartyshov commented Jun 27, 2018

Testing instructions:

  1. Choose logging-level is Record everything or HAR file recording or PCAP file recording or all those params
  2. Starting protection

Expected result:
A warning notification about slow work will appear

@vozersky

This comment has been minimized.

Copy link
Member

@vozersky vozersky commented Jul 26, 2018

The notification doesn't disapperar, when you disable "Record everything" log or HAR file recording or PCAP file recording in settings @nkartyshov

@vozersky vozersky closed this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.