Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If "block ads in apps" is disabled, we should gray out "Ad blocking" setting in the per-apps settings #1484

Closed
ameshkov opened this issue Sep 27, 2017 · 3 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Sep 27, 2017

Apps Management -> App details

@ameshkov ameshkov added this to the 2.11 milestone Sep 27, 2017
@nkartyshov

This comment has been minimized.

Copy link
Contributor

@nkartyshov nkartyshov commented Feb 7, 2018

done

@nkartyshov nkartyshov closed this Feb 7, 2018
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Feb 12, 2018

Issues:

  • Switching checkboxes is very slow
  • "Enabled" box does not work at all
  • Disabling and enabling "ad blocking" makes "https filtering" editable for apps that target nougat
  • Disabling https filtering for an app that targets nougat should also remove that app from the "enforce https filtering" list
@ameshkov ameshkov reopened this Feb 12, 2018
@ameshkov ameshkov assigned Revertron and unassigned nkartyshov Feb 12, 2018
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Feb 16, 2018

Done

@ameshkov ameshkov closed this Feb 16, 2018
@vozersky vozersky reopened this Mar 2, 2018
@vozersky vozersky closed this Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.