Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1st line of imported user filter rules is always interpreted as actual rule #1717

Closed
akmLaVx opened this issue Feb 4, 2018 · 3 comments
Closed
Assignees
Labels
Bug
Milestone

Comments

@akmLaVx
Copy link

@akmLaVx akmLaVx commented Feb 4, 2018

Steps to reproduce

  1. Import any user filter rules list from URL
  2. The first line will always be counted as rule, even when it is commented

Expected behavior

Filter should correctly recognize and omit commented lines.

Actual behavior

The first line will always be counted as rule, even when it is commented

Customer ID

1553302

Your environment

Repro

  • Adguard version: 2.10.176
  • Adguard filtering mode: VPN
  • Device model: LG D405
  • Operating system and version: Android 5.0
  • Rooted or not?: No
  • Any other apps that can start VPN/Antiviruses/Cleaners etc. installed?: None
@zebrum

This comment has been minimized.

Copy link
Member

@zebrum zebrum commented Feb 5, 2018

#1313

need to recheck.

@akmLaVx any specific file you try to import?

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Feb 5, 2018

Original reporter here...

Try this URL
https://docs.google.com/document/d/1owQufJEU1nCwYe4wrj7asssC8a0NkGxr1zM0Xdck9k8/export?format=txt

Edit:
Here's what it looks like on my end...
screenshot_2018-02-05-10-27-24

@zebrum zebrum added Bug and removed Waiting for repro labels Feb 16, 2018
@zebrum zebrum added this to the 2.11 milestone Feb 16, 2018
@nkartyshov

This comment has been minimized.

Copy link
Contributor

@nkartyshov nkartyshov commented Feb 16, 2018

fixed

@nkartyshov nkartyshov closed this Feb 16, 2018
@vozersky vozersky reopened this Mar 2, 2018
@vozersky vozersky closed this Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.