Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a checkbox that disables Assistant and Filtering Log #1808

Closed
ameshkov opened this issue Mar 29, 2018 · 7 comments
Closed

Add a checkbox that disables Assistant and Filtering Log #1808

ameshkov opened this issue Mar 29, 2018 · 7 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Mar 29, 2018

The filtering log's impact on CPU usage is zero, however, we're getting requests from people confused by the "CPU usage" toast in v2.10.

See the details:
#1808 (comment)

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented Mar 30, 2018

Yes, I really need a switch for disabling Filtering Log.

After I record some log and want to check, I need a switch for stopping logging, otherwise I have no method to stop logging.

Please let the switch back!
Both AdGuard for Android and iOS.
Thanks.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Apr 2, 2018

@lancelot-moon Would a switch to visually freeze the log do you (but not altogether stop it)? I'm concerned about forgetting to restart or missing something necessary, due to, e.g., #1074 (comment).

@ameshkov ameshkov added this to the 2.12 milestone Apr 14, 2018
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Apr 14, 2018

This switch will be added to the low-level settings and called pref.enable.filtering.log.

When this switch is disabled, we need to:

  1. Stop the filtering log
  2. Hide the "assistant" button from AdGuard notification

I still think that all the people requesting for such an option do it purely because they saw the misleading notification about CPU/memory usage in v2.10. So after some time they'll get used to the new scheme and see that there's absolutely no difference. Meanwhile, let's have a new flag :).

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Apr 16, 2018

Useful comment:
#1828 (comment)

It indeed might be useful to pause filtering log at some point. Low-level preference won't solve it.

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented Apr 16, 2018

In the past, I already told about it.
But you didn't understand.

After I record some log and want to check, I need a switch for stopping logging, otherwise I have no method to stop logging.

I hate that the log is constantly logging when I only need to check somewhere.
I need the switch to "pause".
You should let the switch be put above log in AG for Android and iOS.

@Nzzyme

This comment has been minimized.

Copy link

@Nzzyme Nzzyme commented Apr 25, 2018

+1 to get the toggle switch back on the Filtering Log page.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented May 3, 2018

It's already here in the nightly, guys

@vozersky vozersky closed this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.