Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show 7+ HTTPS filtering warning when the certificate is in the system store #1855

Closed
ameshkov opened this issue May 6, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented May 6, 2018

Relevant discussion:
https://forum.xda-developers.com/showpost.php?p=76423776&postcount=3143

Steps to reproduce

  1. Move the certificate to the system store
  2. Go to "Apps management"
  3. Find an app there
  4. Uncheck the HTTPS filtering flag
  5. Check it again

Expected behavior

The checkbox value changes with no questions asked

Actual behavior

AdGuard shows the HTTPS filtering warning despite the certificate is in the system store.

Your environment

  • Adguard version: 2.12.4 nightly
  • Adguard filtering mode: VPN
  • Operating system and version (e.g. Android 7.1.2): any Android 7+
  • Rooted
@ameshkov ameshkov added this to the 2.12 milestone May 6, 2018
@admitrevskiy

This comment has been minimized.

Copy link

@admitrevskiy admitrevskiy commented May 7, 2018

Looks like this bug was fixed here: #1825
This branch was merged after last nightly release

@ianmacd

This comment has been minimized.

Copy link

@ianmacd ianmacd commented May 14, 2018

When is the next nightly coming? Perhaps you should rename it 'weekly'. :-)

Just kidding. You guys do fantastic work. I'm just looking forward to having the fix.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented May 14, 2018

This week I guess :)

@vozersky vozersky closed this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.