Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "Notification Icon" option: "Notification without icon" #222

Closed
vbagirov opened this issue Dec 10, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Dec 10, 2015

It's be appreciated if this could all be combined into 1 single-height notification — there is some functionality loss when all notifications reach > 1 screen height (much harder to expand notifications).

@tobia

This comment has been minimized.

Copy link

@tobia tobia commented Dec 10, 2015

I'm not sure what @TPS is referring to.

My request, as per the screenshot above, is to have Adguard's notification in the ongoing or permanent area.

The problem with the current kind of notification is that it comes up on the locked screen, it lights up the notification LED, and so on, as if it were an unread message, which it's not.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Dec 10, 2015

Ahh, I understand now. I've no experience with this with Android 4.4.x, as everything's just mixed together. I thought this was requesting for the (marked-off area in AG in that screenshot) # of blocked ads to appear in an additional notification, so my comment is in that context.

@ameshkov ameshkov added this to the 2.1 patch 2 milestone Dec 11, 2015
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Dec 14, 2015

@tobia it seems that the problem was not in "ONGOING" flag.
To achieve what you want our notification priority should be set to PRIORITY_MIN.

So, what I have done:

  1. If "Notification icon" is set to "None", we show notification with minimum priority. In this case it looks like in "Avast" away, no icon and grayed out notification.
  2. If "Notification icon" is set to "None", we simply show the notifcation + icon.
  3. In both cases we now set FLAG_ONGOING_EVENT. It does not change UI appearance, but I hope this will increase the app priority.
@ameshkov ameshkov closed this Dec 14, 2015
@ameshkov ameshkov changed the title [Feature request] Make Adguard notification ongoing (like music players etc.) Add a new "Notification Icon" option: low priority icon Dec 15, 2015
@ameshkov ameshkov reopened this Dec 15, 2015
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Dec 15, 2015

Change of plans.

Instead of changing how "NONE" works, we'll introduce one more option: "Notification without icon".
In this case Adguard's icon is not visible, but notification is visible and grayed out.

@ameshkov ameshkov changed the title Add a new "Notification Icon" option: low priority icon Add a new "Notification Icon" option: "Notification without icon" Dec 15, 2015
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Dec 15, 2015

Done

@ameshkov ameshkov closed this Dec 15, 2015
@ameshkov ameshkov changed the title Add a new "Notification Icon" option: "Notification without icon" New "Notification Icon" option: "Notification without icon" Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.