Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using our dnsproxy as an underlying DNS client (+DNS-over-TLS support) #2415

Closed
ameshkov opened this issue Dec 25, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@ameshkov
Copy link
Member

commented Dec 25, 2018

Instead of bundling with the dnscrypt-proxy binaries, we can start using our own implementation that supports every known protocol.

Here it is:
https://github.com/AdguardTeam/dnsproxy

(see the PR with the mobile build here: DNS/repos/dnsproxy/pull-requests/2/overview -- not yet published to github)

Here is what needs to be done:

  1. Change the format supported for DNS addresses: https://uploads.adguard.com/up04_z8zfz_AdGuard_Home.png
    Please note, that DNS stamps are supported for DNSCrypt and DoH clients ONLY. We do not support it for DoT so you'll need to explicitly convert it to tls://
  2. Setting bootstrap DNS is necessary (make it configurable via advanced settings though: pref.dns.bootstrap)
  3. Setting fallback DNS is also necessary. We should use the system default.
  4. Regarding the build process, once we are sure that the mobile build is okay, we should start publishing aar to our archiva and start versioning them.
@admitrevskiy

This comment has been minimized.

Copy link

commented Jan 25, 2019

Resolved.

Testing instructions for QA:
-Add some DNS servers at the DNS screen.
-Reinstall AG (try to update from latest nightly and from 2.12.247)
-Go to Custom DNS Settings screen.

-Try to add server from KB.

-Examine DNS with different protocol upstreams (regular, DNSCrypt, DoT and DoH)

-Add and choose new invalid DNS server (for example 1.2.3.4)
-Enable protection

Expected result:
-Internet is still available

@ameshkov ameshkov changed the title Start using our dnsproxy as an underlying DNS client Start using our dnsproxy as an underlying DNS client (+DNS-over-TLS support) Jan 25, 2019

@zzebrum zzebrum closed this Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.