Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering Log shows most of traffic that is explicitly allowed by the User Filter without the green background color #2474

Closed
SergeiShir opened this issue Jan 27, 2019 · 11 comments
Assignees
Labels
Milestone

Comments

@SergeiShir
Copy link

@SergeiShir SergeiShir commented Jan 27, 2019

After the latest upgrade, I encounter the following issue:
Most of the traffic that my User Filter allows is shown without a background color (and as "Status = Processed") instead of the green background (and as "Status = Whitelisted"). There is no apparent pattern - this issue occurs for different User Filter rules - rules for DNS connections, rules for connections from specific apps, rules for URL connections.
However, the traffic that is explicitly blocked the User Filter, is still always shown with the red background color.

Steps to reproduce

  1. Open an app, or browse to some sites to initiate connections that are explicitly allowed by the User Filter.
  2. Open Filtering Log.
  3. Most of these connections are shown without a background color - when you open such log entries, it shows "Status = Processed" + "Filter Name = User Filter".
  4. There are still connections that are shown with the green background - such log entries show "Status = Whitelisted" + "Filter Name = User Filter".

Expected behavior

All connections that are explicitly allowed by the User Filter should be shown as green

Actual behavior

Most of the allowed connections are shown without a background color

Screenshot: Will be attached shortly

(1 of 2) Example of allowed connections that are shown without background color:

filteringlog_no_background_color

(2 of 2) Example of an entry:

filteringlog_entry

Customer ID

Premium 1146569

Your environment

  • Adguard version: 3.0.195n (1.3.94cl)
  • Adguard filtering mode: VPN
  • Device model: Google Pixel 2 XL
  • Operating system and version: stock Android 9, security patch 05 Jan 2019
  • Rooted or not? Not rooted
  • Any other apps that can start VPN/Antiviruses/Cleaners etc. installed? No

Logs and Settings

adguard_logs_3.0.195_27Jan_09h30m.zip

@SergeiShir SergeiShir changed the title Filtering Log shows most of traffic that is explicitly allowed by the User Filter without green background color Filtering Log shows most of traffic that is explicitly allowed by the User Filter without the green background color Jan 27, 2019
@ameshkov ameshkov added this to the 3.0 milestone Jan 28, 2019
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Jan 28, 2019

@SergeiShir you have this issue with DNS requests only, right?

@SergeiShir

This comment has been minimized.

Copy link
Author

@SergeiShir SergeiShir commented Jan 28, 2019

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Jan 28, 2019

@Revertron I guess it's caused by the CL 1.3 pull request you were implementing, please take a look.

Try unblocking requests from the filtering log to reproduce the issue.

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented Jan 28, 2019

This is actually duplication with mine.
Some whitelisted requests are correctly shown as "whitelisted", but others are not so (only processed).
#2471

Because AG think they're only processed requests, some whitelisted requests are without the light green background.

@SergeiShir

This comment has been minimized.

Copy link
Author

@SergeiShir SergeiShir commented Jan 30, 2019

Just upgraded to the latest Nightly.
The situation is much better (~85% are whitelisted as expected), but still there are many missed (just processed).
See the attached logs.

[Removed logs link for privacy reasons]

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Jan 30, 2019

@SergeiShir plz send logs to devteam@adguard.com next time, it might be not okay to share the file here

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Jan 30, 2019

@SergeiShir could you please show or describe a couple of examples of such wrongly "processed" requests?

@SergeiShir

This comment has been minimized.

Copy link
Author

@SergeiShir SergeiShir commented Feb 1, 2019

Can you GREP the attached logs for these 2 conditions?
Status = Processed
AND
Filter name = User Filter

If not, let me know...

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 1, 2019

Well, the filtering log events aren't written to the log file, the data there is raw. So the question is which requests representation in the filtering log is wrong.

@SergeiShir

This comment has been minimized.

Copy link
Author

@SergeiShir SergeiShir commented Feb 1, 2019

As requested, I sent the new log files to devteam email
Subject = Files for GitHub bug 2474
Sent = 17:34 GMT+2

I attached 2 sets of logs together with screenshots from the Filtering Log that show the problematic entries

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 6, 2019

@SergeiShir got the logs and screenshots, thank you!

@Revertron it seems that HTTPS Tunnel evens with a whitelisted rule applied falsely marked as "Processed" instead of "Whitelisted". The problem might be on the CL side, though.

@zzebrum zzebrum closed this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.