Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall temporary unblock notification is shown every minute #251

Closed
ameshkov opened this issue Dec 27, 2015 · 6 comments

Comments

@ameshkov
Copy link
Member

commented Dec 27, 2015

Steps to reproduce:

  1. Disable network access for an app
  2. Start the app
  3. Do nothing with unblock notification and continue working with the app
  4. Notification will be shown again in a minute
@ameshkov ameshkov added this to the 2.6 milestone Dec 27, 2015
@TPS

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2015

Is this a particular app? For any of the apps I have such notifications, it only happens once per attempt by the app. Is this then to rate-limit these notifications in some fashion? If so, could that rate be configurable?

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2015

According to user it happens for every app.

I think we simply shouldn't repeat this notification until the app goes background and foreground again.

@Revertron

This comment has been minimized.

Copy link
Member

commented Jun 8, 2016

Okay, I've blocked internet access for com.alensw.PicFolder (QuickPic gallery app) and I see following behavior:
The app is trying to connect to its servers constantly, without any pause.
We are clearing last notified package variable after 1min timeout. I will rethink the mechanism right now...

@Revertron

This comment has been minimized.

Copy link
Member

commented Jun 8, 2016

If we remove the code that clears timeout, this case will not work:
User starts blocked app, it tries to connect, we block and notify user.
After using the app user is quiting it, goin to some other app.
After a minute user goes to this blocked app once more and he will not get our notification again.
If he decides to use Internet in that app he will have to go to firewall settings to enable it (not temporarily).

The problem is - we do not constantly check foregroundness of blocked app, only on blocking event.

@Revertron

This comment has been minimized.

Copy link
Member

commented Jun 8, 2016

Yahoo! I've found a way :)

@Revertron Revertron closed this Jun 8, 2016
@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2016

What was it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.