Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGuard can no longer recognise its SSL cert in system store. #2675

Closed
ianmacd opened this issue Apr 2, 2019 · 1 comment
Closed

AdGuard can no longer recognise its SSL cert in system store. #2675

ianmacd opened this issue Apr 2, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@ianmacd
Copy link

@ianmacd ianmacd commented Apr 2, 2019

It seems that AdGuard can no longer recognise that its SSL cert has been installed into the system store.

I have 3 devices (all Samsung: S9+, S10+ and Tab S4), all rooted and all running the latest AdGuard nightly in auto-proxy mode.

Since very recently, possibly since the release of Magisk v19, AdGuard has been failing to detect that its SSL certificate is installed in the system store. I am using the Magisk Move Certs module and have verified that it is working correctly, i.e. the AdGuard cert is properly moved at boot time.

Even stranger is that when I try to turn on HTTPS Filtering in AdGuard, it creates the cert again (even though there is already one in the system store), but then toggles HTTPS Filtering off again.

The usual message that Magisk has been detected and that the Move Certs module should be used never appears, and the cert doesn't even get installed into the user store.

So, a couple of weird things are going on here. The system store cert is ignored and creating a new cert mysteriously fails. And Magisk isn't properly being detected, probably because whichever test you are using ceased to be true in Magisk v19.

@ameshkov ameshkov added this to the 3.1 milestone Apr 2, 2019
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Apr 10, 2019

Additional info from the Telegram chat:

In fact, there's a second issue if one selects the 'Move Anyway' option after Magisk is detected on a system-as-root device.

Magisk mounts the actual system on these devices under /system_root, not /system, so AdGuard's attempt to move the cert fails and it must be done by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.