Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do search results in filtering log not include blocked URL which match keywords? #2681

Closed
lancelot-moon opened this issue Apr 4, 2019 · 6 comments

Comments

@lancelot-moon
Copy link

commented Apr 4, 2019

@ameshkov

Enable pref.removed.html.log in low settings of AG for Android.
I type the keywords of blocked URL (Event type: Removed HTML element) in the search of filtering log.
But it shows nothing.

It seems that it only shows requests of request URL and source URL which match the keywords.

It doesn't show requests of blocked URL which matches keywords.

ex: Search cdnjs but show nothing in the filtering log.

Screenshots:

image

image

image


@lancelot-moon lancelot-moon changed the title Do search results in filtering log not include blocked URL? Do search results in filtering log not include requests of removed HTML element? Apr 4, 2019
@lancelot-moon lancelot-moon changed the title Do search results in filtering log not include requests of removed HTML element? Do search results in filtering log not include blocked URL which match keywords? Apr 4, 2019
@lancelot-moon

This comment has been minimized.

Copy link
Author

commented Apr 5, 2019

@ameshkov

In the filtering log of AG for Windows, there are request URL and source URL in requests (no Blocked URL).
So if I search cdnjs, those requests can be shown.

Screenshot:

image


Enable pref.removed.html.log in low settings of AG for Android.
And then go to visit https://www.linetv.tw/drama/10052/eps/1.
Please don't directly open https://cdnjs.cloudflare.com/...........

In the filtering log of AG for Android:
Blocked URL: https://cdnjs.cloudflare.com/...........
Request URL: https://www.lintv.tw/...........

In the filtering log of AG for Windows:
Source URL: https://www.lintv.tw/...........
Request URL: https://cdnjs.cloudflare.com/...........

Different.

@Revertron

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Screenshot_1554467646
In my test it is Blocked, not Removed. And it is shown in a search.

@lancelot-moon

This comment has been minimized.

Copy link
Author

commented Apr 5, 2019

@Revertron

Try to enable pref.removed.html.log in low settings.
Go to visit https://www.linetv.tw/drama/10052/eps/1.
You'll see that request of Event type: Removed HTML element in the filtering log.
Please don't directly open https://cdnjs.cloudflare.com/...........

@AdamWr
Maybe need Taiwanese IP.
May you help?
Thanks.

@Revertron

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

I couldn't repeat this with cdnjs, but with pagead2 I see this problem.
I think it is a bug.

@lancelot-moon

This comment has been minimized.

Copy link
Author

commented Apr 5, 2019

Yes, it's ok.
Just try to search keywords in the Blocked URL of any requests whose Event type: Removed HTML element in the filtering log.
(First enable pref.removed.html.log in low settings.)

Thanks for your confirmation.
I think it's a bug, too.

I remember that you'll improve the filtering log in v3.1.
Please fix together.

@zzebrum zzebrum added this to the 3.2 milestone Apr 8, 2019
@Revertron

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Fixed.
Testing:

  1. Enable pref.removed.html.log in low settings of AG for Android.
  2. Go to https://www.linetv.tw/drama/10052/eps/1
  3. I type the keywords of blocked URL (Event type: Removed HTML element) in the search of filtering log, such as "cdnjs" or "pagead2". Some of removed HTML events must be shown.
@TheHasagi TheHasagi closed this Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.