Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Android system language is Chinese (or Portuguese), auto detection for AG's language interface is failed. #2684

Closed
lancelot-moon opened this issue Apr 7, 2019 · 7 comments
Assignees
Milestone

Comments

@lancelot-moon
Copy link

@lancelot-moon lancelot-moon commented Apr 7, 2019

In now situation, the setup wizard is English after first time of installation.
But translators actually have translated the setup wizard.

Please show language selection and then go to the setup wizard after first time of installation.
Or AG will automatically detect Android system language and show the translated setup wizard.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Apr 7, 2019

Or AG will automatically detect Android system language and show the translated setup wizard.

Well, AG does detect the Android system language and show the translated wizard, how else could it be.

In now situation, the setup wizard is English after first time of installation.
But translators actually have translated the setup wizard.

I cannot reproduce this

@sfionov

This comment has been minimized.

Copy link
Member

@sfionov sfionov commented Apr 7, 2019

May be related to #2651

@lancelot-moon

This comment has been minimized.

Copy link
Author

@lancelot-moon lancelot-moon commented Apr 8, 2019

@ameshkov

Try to switch your Android system language to Traditional Chinese (繁體中文).
My language preference in Android v8.0:

  1. Traditional Chinese (Taiwan) - Default language
  2. English (United States)
Screenshot:

image


I think @sfionov may be right.
There is a bug there.

Currently it is a problem only for Chinese and Portuguese locales.

I reinstalled AG v3.0.310η for screenshots.

a. When Android system language is Traditional Chinese, the initial setup wizard is English.
[ Even if removing English (United States) but only leaving Traditional Chinese (Taiwan) - Default language in my language preference of Android v8.0, the initial setup wizard is still English. ]

Screenshots:

image

image

image

image


b. After my first time of installation, AG app automatically sets English as its language interface.
I suppose that AG app should automatically set system (Traditional Chinese) or Traditional Chinese as its language interface at least.

Screenshots:

image

image


c. When Android system language is Traditional Chinese, AG app shows the system language is English.
But AG app will be Traditional Chinese interface when choosing system (English).
It should be 系統 (繁體中文) [ system (Traditional Chinese) ], not 系統 (English).

Screenshots:

image

image


@lancelot-moon

This comment has been minimized.

Copy link
Author

@lancelot-moon lancelot-moon commented Apr 8, 2019

@northis
@Stillness-2

May you check if AG for Windows/Mac has the same issue?
[ All of AG products are 100% translated to Traditional Chinese (zh-TW) on onesky. ]

I mean AG for PC may not normally detect system language so that the setup wizard (installer) is English, not localized.

@northis
Have you updated the locales of Adguard UI, Burn-Installer and Wix-Installer for AG for Windows?

@TheHasagi

This comment has been minimized.

Copy link
Contributor

@TheHasagi TheHasagi commented Apr 8, 2019

Successfully reproduced.

@lancelot-moon lancelot-moon changed the title After first time of installation, show language selection first. When Android system language is Chinese (or Portuguese), auto detection for AG's language interface is failed. Apr 8, 2019
@ameshkov ameshkov modified the milestones: 3.2, 3.1 Apr 8, 2019
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Apr 8, 2019

Reassigned to v3.1

@artemiv4nov artemiv4nov assigned artemiv4nov and unassigned Revertron Apr 16, 2019
@lancelot-moon

This comment has been minimized.

Copy link
Author

@lancelot-moon lancelot-moon commented May 1, 2019

@artemiv4nov

@sfionov is correct.
#2651

This is fixed in v3.0.344η.

a. When Android system language is Traditional Chinese (繁體中文, locale: zh-TW), the initial setup wizard is Traditional Chinese.

Screenshots:

image

image

image

image


b & c. After my first time of installation, AG app automatically sets system (Traditional Chinese) as its language interface.
When Android system language is Traditional Chinese, old AG app wrongly showed system (English).
But AG v3.0.344η can correctly show 系統 (繁體中文) = system (Traditional Chinese) .

Screenshot:

image


d. The blocking page can be Traditional Chinese in v3.0.344η.
Well, I ever requested to update the translations of blocking page.
AdguardTeam/CoreLibs#805

Screenshot:

image


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.