Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate in the UI that AG cannot filter itself #2700

Closed
ameshkov opened this issue Apr 10, 2019 · 1 comment
Closed

Indicate in the UI that AG cannot filter itself #2700

ameshkov opened this issue Apr 10, 2019 · 1 comment
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Apr 10, 2019

Enabling filtering for AG itself was leading to multiple issues so we had to add it exceptions. We should find a way to indicate this in the UI (or we might need to simply remove AG from the filtered apps list).

We could also add a low-level flag that controls if AG is excluded or not.

@admitrevskiy

This comment has been minimized.

Copy link

@admitrevskiy admitrevskiy commented Jun 13, 2019

Done.

Testing instructions for QA:

  • Reinstall AG
  • Go to Apps Management -> AdGuard

Expected result:

  • You will see warning about AG not being able to filter itself
  • AG settings cannot be changed
@TheHasagi TheHasagi closed this Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.