Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG breaks captive portals authentication #2713

Closed
ameshkov opened this issue Apr 20, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Apr 20, 2019

Steps to reproduce

  1. Connect to Wi-Fi hotspot that has some captive portal
  2. Android will ask you if you want to sign in
  3. Agree and try to sign in

Expected result

You should see the captive portal

Actual result

White empty page

Logs

Uploaded to the private nextcloud

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Apr 20, 2019

To fix this we should simply disable filtering for com.google.android.captiveportallogin.

@ameshkov ameshkov added this to the 3.1 milestone Apr 20, 2019
@rWolstenholme

This comment has been minimized.

Copy link

@rWolstenholme rWolstenholme commented May 29, 2019

AOSP/MIUI uses com.android.captiveportallogin, I think for the same reasons it should treated similarly

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented May 29, 2019

@rWolstenholme makes sense, thank you! We'll add it to the default exceptions list.

@zzebrum zzebrum closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.