Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stealth mode settings dialogs #2808

Closed
ameshkov opened this issue Jun 17, 2019 · 1 comment

Comments

@ameshkov
Copy link
Member

commented Jun 17, 2019

For some unknown reason, all dialogs (tracking parameters, ttl, etc) ask users to enter "Domain name". This is wrong.

  1. We should let users edit the current value, not just fill the field
  2. There should be the "Cancel" button in the dialog
@admitrevskiy

This comment has been minimized.

Copy link

commented Jun 21, 2019

Done.

Testing instructions for QA:

  • Reinstall AG
  • Go to Stealth Mode
  • Try to change any value

Expected result:

  • There is Cancel button in the dialog
  • No more Enter domain hints
  • Current value is visible in the dialog
  • New value is saved after dialog confirmation
@TheHasagi TheHasagi closed this Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.