Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while saving exported settings json file (replace with existing) #2906

Closed
TheHasagi opened this issue Jul 9, 2019 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@TheHasagi
Copy link
Contributor

@TheHasagi TheHasagi commented Jul 9, 2019

If you try to export the settings with the same as existing one it should ask you to replace the item or no, actually it saves the file with (1).json format, but shows an error message (see the screenshot)

Steps to reproduce

  1. Open Adguard - settings - general - export settings - save the file with a name a.json
  2. Go back to general - export settings - try to save the file with name a.json - tapn to save

Expected behavior

It should ask you to replace the file with an existing name

Actual behavior

It saves the file (actually), but shows an error (that’s incorrect)

Screenshot:

img

@TheHasagi TheHasagi added this to the 3.2 milestone Jul 9, 2019
@admitrevskiy

This comment has been minimized.

Copy link

@admitrevskiy admitrevskiy commented Jul 22, 2019

Done.

@TheHasagi TheHasagi closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.