New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-HTTP data to port=80 should be bypassed, not just dropped #294

Closed
PaulMarkey1 opened this Issue Jan 23, 2016 · 9 comments

Comments

Projects
None yet
6 participants
@PaulMarkey1

PaulMarkey1 commented Jan 23, 2016

Original issue: messages cannot be sent in Telegram app.

@ameshkov

This comment has been minimized.

Member

ameshkov commented Jan 24, 2016

Here is the problem:

04:43:49.490 [pool-2-thread-9] DEBUG c.a.f.proxy.BaseHttpProxyServer - TCP id=100008 Server accepted new tcp connection
04:43:49.491 [pool-2-thread-9] DEBUG com.adguard.android.FilteringLog - TCP id=100008 got connection org.telegram.messenger /172.16.16.1:52214 /149.154.167.51:80 10100
04:43:49.495 [pool-2-thread-9] DEBUG c.a.f.proxy.BaseHttpProxyServer - TCP id=100008 Reading HTTP request
04:43:49.514 [Thread-1266] DEBUG c.a.c.io.SocketPollingSelector - TCP id=100008 Read 138 bytes from socket channel
04:43:49.515 [pool-2-thread-9] DEBUG c.a.f.proxy.BaseHttpProxyServer - TCP id=100008 Cannot read HTTP request Http base line violates protocol: ï"4�¾è�ÚT*ùq��.ùðK×��·û�Í��é?þ���
04:43:49.516 [pool-2-thread-9] DEBUG c.a.f.proxy.BaseHttpProxyServer - TCP id=100008 Closing HTTP connection
04:43:49.516 [pool-2-thread-9] DEBUG c.a.android.filtering.filter.a - TCP id=100008 Closing http proxy connection context
04:43:49.516 [pool-2-thread-9] DEBUG c.a.f.proxy.TcpConnectionContext - TCP id=100008 Closing connection
04:43:49.517 [pool-2-thread-9] DEBUG c.a.f.proxy.TcpConnectionContext - TCP id=100008 Connection has been closed
04:43:49.517 [pool-2-thread-9] DEBUG c.a.android.filtering.filter.a - TCP id=100008 Http proxy connection context has been closed
04:44:03.696 [pool-2-thread-8] DEBUG c.a.android.filtering.filter.a - TCP id=100008 Closing http proxy connection context
04:44:03.697 [pool-2-thread-8] DEBUG c.a.android.filtering.filter.a - TCP id=100008 Http proxy connection context has been closed

Telegram sends non-HTTP data to port=80.

In this case we should bypass data, not just close the connection.

@ameshkov ameshkov closed this Jan 24, 2016

@ameshkov

This comment has been minimized.

Member

ameshkov commented Jan 24, 2016

Deleted

@ameshkov ameshkov reopened this Jan 24, 2016

@ameshkov ameshkov added this to the 2.5 milestone Jan 24, 2016

@ameshkov

This comment has been minimized.

Member

ameshkov commented Jan 24, 2016

Temporary workaround: disable ad filtering for Telegram in Adguard's firewall.

@ameshkov ameshkov changed the title from The problem with the update data in Telegram to Non-HTTP data to port=80 should be bypassed, not just dropped Jan 25, 2016

@TPS

This comment has been minimized.

Contributor

TPS commented Feb 22, 2016

Now that #21 is landing, maybe expand this to include non-http _&_ non-http**S**?

@ameshkov

This comment has been minimized.

Member

ameshkov commented Feb 23, 2016

That's a good question.

Btw the original issue should be now fixed (along with #21).
But "non-HTTP over TLS" is still possible, yet I'd better wait for a real example before fixing it:)

@ameshkov

This comment has been minimized.

Member

ameshkov commented Feb 26, 2016

Haha, here is a real example:
#322

@Bohdan-SUP

This comment has been minimized.

Bohdan-SUP commented Mar 1, 2016

Excluding Telegram from filtering didn't help for this user.
Logs here - KOB-718-28059

@ameshkov

This comment has been minimized.

Member

ameshkov commented Mar 1, 2016

@Bohdan-SUP which logs exactly? Telegram compatibility?

Temporary workaround: disable ad filtering for Telegram in Adguard's firewall.

@ameshkov

This comment has been minimized.

Member

ameshkov commented Mar 14, 2016

Fixed

@ameshkov ameshkov closed this Mar 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment