Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Apache AvailablePortFinder #2995

Closed
sfionov opened this issue Aug 7, 2019 · 1 comment
Closed

Get rid of Apache AvailablePortFinder #2995

sfionov opened this issue Aug 7, 2019 · 1 comment
Assignees
Milestone

Comments

@sfionov
Copy link
Member

@sfionov sfionov commented Aug 7, 2019

Binding to port 0 is more reliable in any cases. Also, current implementation keeps open socket at port 1100.

But support of binding to port 0 requires API methods to retrieve port to which server was bound.

Linked CoreLibs issue:
AdguardTeam/CoreLibs#1028

@admitrevskiy

This comment has been minimized.

Copy link

@admitrevskiy admitrevskiy commented Oct 1, 2019

Done.

Testing instructions for QA:

  • Reinstall AG
  • Examine possible protection restart cases for different filtering methods and configurations
@zzebrum zzebrum closed this Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.