Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling network access globally blocks DNS requests #3025

Closed
ameshkov opened this issue Aug 25, 2019 · 0 comments

Comments

@ameshkov
Copy link
Member

commented Aug 25, 2019

Steps to reproduce

  1. Apps Management -> Settings -> Disable net access there
  2. Try opening any website

Issue details

Most likely, this is the reason for the issue that people have here:
https://forum.adguard.com/index.php?threads/adguard-for-android-3-2-140-hotfix.34670/

On one side, this behavior is not wrong. The problem here is that blocking network access for the DNS requests effectively blocks it for all other apps as well.

The second issue is that AdGuard won't show the "blocked access" notification about the DNS requests being blocked.

How can we fix this?

Two options:

  1. We can make an exception for DNS requests and not block them
  2. We can make the "firewall notifications" work for DNS requests so that this was not a surprise for the user.

Tbh, I like the second option more

@ameshkov ameshkov added this to the 3.2 milestone Aug 25, 2019
@artemiv4nov artemiv4nov self-assigned this Aug 25, 2019
@TheHasagi TheHasagi closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.