Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty ad placeholders are visible in some apps with HTTPS filtering enabled #402

Closed
vbagirov opened this issue Mar 28, 2016 · 14 comments

Comments

Projects
None yet
4 participants
@vbagirov
Copy link
Member

commented Mar 28, 2016

In some apps listed in this thread: http://forum.adguard.com/showthread.php?9905

ads are blocked with HTTPs filtering DSIABLED, and are present with HTTPs filtering ENABLED.

@vbagirov vbagirov added the Bug label Mar 28, 2016

@ameshkov ameshkov added this to the 2.5 milestone Mar 30, 2016

@ameshkov

This comment has been minimized.

Copy link
Member

commented Mar 30, 2016

The issue name is misleading, i'll change it.

@ameshkov ameshkov changed the title HTTPS filtering doesn't work - ads are missing Empty ad placeholders are visible in some apps with HTTPS filtering enabled Mar 30, 2016

@ameshkov

This comment has been minimized.

Copy link
Member

commented Mar 30, 2016

http://forum.adguard.com/showthread.php?9905-HTTPS-filtering-not-working&p=81053&viewfull=1#post81053

Also I think I know the reason.

You see, when it is disabled, the app cannot connect to the blocked domain.
But when it's enabled, AG emulates an empty server response instead.

Generally, the second way is safer. For instance, an app won't try to reload ads.

Also I suppose the issue can be solved on the filters level. Instead of empty response AG may emulate a server error, it may help.

@TPS

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2016

I suppose make it another option under Filter HTTPS connections, but I think those of us with Filter DNS requests are used to the previous behavior.

@ameshkov

This comment has been minimized.

Copy link
Member

commented Mar 30, 2016

No, why, it should not be done app-wide, I am talking about filter rules modifiers.

I suppose the ad network was blocked by a rule with an $empty modifier. Removing this modifier will change the way it works and instead of empty response AG will return "server error" response.

@ameshkov

This comment has been minimized.

Copy link
Member

commented Apr 12, 2016

I suppose this issue will be solved with a new beta version (coming soon).

@ameshkov ameshkov closed this Apr 12, 2016

@ameshkov ameshkov modified the milestones: 2.6, 2.5 Apr 29, 2016

@ameshkov ameshkov reopened this Apr 29, 2016

@ameshkov ameshkov assigned ameshkov and unassigned Revertron Apr 29, 2016

@ameshkov

This comment has been minimized.

Copy link
Member

commented Apr 29, 2016

@ameshkov

This comment has been minimized.

@ameshkov

This comment has been minimized.

Copy link
Member

commented May 4, 2016

@ameshkov

This comment has been minimized.

Copy link
Member

commented May 16, 2016

No placeholders when we return error response instead of 204 no content.

@ameshkov

This comment has been minimized.

Copy link
Member

commented May 16, 2016

@ameshkov

This comment has been minimized.

Copy link
Member

commented May 16, 2016

Caller ID also seems to be clean when we return status=500

@ameshkov ameshkov closed this May 16, 2016

@ameshkov

This comment has been minimized.

Copy link
Member

commented May 23, 2016

@ameshkov ameshkov reopened this May 23, 2016

@Revertron

This comment has been minimized.

Copy link
Member

commented May 23, 2016

I think we need to send different responses to different requests. :-/

@ameshkov

This comment has been minimized.

Copy link
Member

commented May 23, 2016

False alarm, user has disabled ad blocking for "Google Services framework" so metadata just was not blocked at all.

@ameshkov ameshkov closed this May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.