Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Adguard widget according to Android guidelines #481

Closed
ameshkov opened this issue Apr 21, 2016 · 19 comments

Comments

Projects
None yet
4 participants
@ameshkov
Copy link
Member

commented Apr 21, 2016

What we've done in #203 with widget is just a temporary solution.
We'll use this icons for #123

http://developer.android.com/intl/ru/guide/practices/ui_guidelines/widget_design.html

@TPS

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2016

Just FYI, from yesterday's beta, the temporary widget states are still swapped.

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2016

Why, no, it is in proper state now. Widget shows you a possible action, not a current state.

@TPS

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2016

That, I think, is a change from previous behavior (please confirm!) & is rather jarring. Shouldn't the notification bar show the same as widget?

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2016

That indeed a change from the previous behavior:)

Shouldn't the notification bar show the same as widget?

Notification bar is for showing current state.
Widget is for actions, a bit different purpose.

New widget will look different, but it will have the same states (like this "player" widget):

@TPS

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2016

I think, though, a utility app, like AG, shouldn't pattern widget states after a media app, like a music player. The other utility apps I'm familiar with use current status for widgets, especially since many have >2 rest states.

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2016

Something like that widget?
2016-04-22_1815

@TPS

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2016

Precisely!

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2016

This widget looks good indeed, but only when you place several actions on it.

@TPS

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2016

The widget has the benefit of being 1×1, which, trust me, is both rare & excellent, so 1 really well-done action is plenty & even laudable. If you want more actions, leave it on 1×1, but as (½×2)×(½×2) max → subdivide the 1×1, if possible. I think it should be, since the widget above is 5 actions on a 4×1 widget!

@TPS

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2016

@AdguardTeam Before releasing later on, are y'all keeping these states as-is (a change from previous release), or reverting to previous states (of course, keeping the Material icons)? I don't quite know where we left this.…

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2016

@TPS not sure yet, our designer will make the decision:)

@Zageron

This comment has been minimized.

Copy link

commented May 9, 2016

Hello, just dropping in to add my support for the widget showing the current state of the blocker, or perhaps having two widgets which display in opposite states.

:)

@ameshkov ameshkov self-assigned this May 11, 2016

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented May 15, 2016

I'll show new widget image as soon as designer comes up with something

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented May 23, 2016

@Revertron
1x1 widget: return the old widget, just use android guidelines for its size. Example: pushbullet 1x1 widget
shortcut: use the current widget icon for the shortcut. Shortcut either stops or starts AG protection.

1x4 widget: in v2.7: #576

@TPS

This comment has been minimized.

Copy link
Contributor

commented May 23, 2016

1x1 widget: return the old widget

Why? Do you mean previous states only? Or use old icons, too?

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented May 23, 2016

Why? Do you mean previous states only? Or use old icons, too?

The old 1x1 widget was just like pushbullet widget:
2016-05-23_1727

@ameshkov ameshkov assigned Revertron and unassigned ameshkov May 25, 2016

@Revertron

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

Made a shortcut:
adguard_shortcut

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2016

@Revertron tapping on a shortcut should also bring up a toast message.
Something like: starting (or stopping) Adguard protection

@Revertron

This comment has been minimized.

Copy link
Member

commented Jun 8, 2016

I think that current widget and new shortcut are great, closing this issue.

@Revertron Revertron closed this Jun 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.