Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an option to disable splash screen on Adguard launch #490

Closed
Revertron opened this issue Apr 25, 2016 · 8 comments
Closed

Make an option to disable splash screen on Adguard launch #490

Revertron opened this issue Apr 25, 2016 · 8 comments
Assignees
Labels
Milestone

Comments

@Revertron
Copy link
Member

@Revertron Revertron commented Apr 25, 2016

In advanced options: pref.splash.enabled. Default: true.

@Revertron Revertron self-assigned this Apr 25, 2016
@Revertron Revertron added this to the 2.5 milestone Apr 25, 2016
@Revertron

This comment has been minimized.

Copy link
Member Author

@Revertron Revertron commented Apr 25, 2016

Done.

@Revertron Revertron closed this Apr 25, 2016
@jccube

This comment has been minimized.

Copy link

@jccube jccube commented Feb 17, 2019

Ad guard splash screen still a problem. After 3 years bitching about this issue, could you please provide option to disable. Additionally I am still somewhat confused that the member Revertron has closed the issue without reason code other than just "an enhancement". Actually I would consider this a quality control issue than an "enhancement". The user (that is myself) does not perceive it as an "enhancement" as fixing this problem provides no real value but rather corrects a design flaw from the beginning.
To remove the splash screen would require about 10 lines of code. What's the holdup??

@Revertron

This comment has been minimized.

Copy link
Member Author

@Revertron Revertron commented Feb 18, 2019

We've changed the behavior of the splash screen to be like in Google's apps.
It is shown only when the initialization of service layer is needed, i.e. when the app is not running at all (or killed by system). The second and next starts you supposed to not see it at all.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 18, 2019

@jccube

  1. You can add comments to closed issues, there's no need to create a new one.
  2. In the version v2.12 there is already a switch for the splash screen
  3. This switch was removed in v3.0 beta because the current behavior is equal to having the splash screen disabled.
  4. The splash screen cannot be completely disabled because of it's nature.

There will be anyway a second when the app is initializing, and at that moment Android will have to show you something. If there's no splash screen, it will be simply an empty white screen.

So the question is what exactly do you want us to do? Provide a switch that will force the "white screen" splash screen instead of the normal splash screen?

Is there any example of the behavior you want us to implement?

@jccube

This comment has been minimized.

Copy link

@jccube jccube commented Feb 18, 2019

@jccube

This comment has been minimized.

Copy link

@jccube jccube commented Feb 18, 2019

And BTW I am referring this request specifically on the windows platform e.g. windows 10. I believe I filed my request under the proper platform.

Regards

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 18, 2019

Ah, that was about Windows! Sorry for that, I've misunderstood it completely.

@jccube

This comment has been minimized.

Copy link

@jccube jccube commented Feb 18, 2019

It is understandable. That is why we are conversing on the issue. To clear things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.