New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a notification about expiring license #606

Closed
Revertron opened this Issue Jun 1, 2016 · 23 comments

Comments

Projects
None yet
6 participants
@Revertron
Member

Revertron commented Jun 1, 2016

If a user has not life-time license key and his key's expiring time is approaching - say 14 days are left, we should show some notification to user so that he/she can renew key.

It can look like this:
screenshot_2016-05-23-12-20-39

Also, we need to save last time when notification is shown and show it every 2 days may be.

@Revertron Revertron added this to the 2.7 milestone Jun 1, 2016

@Revertron Revertron self-assigned this Jun 1, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Jun 6, 2016

Contributor

#605?

Contributor

TPS commented Jun 6, 2016

#605?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jun 6, 2016

Member

Yep, #605 is a duplicate, thank you:)

Member

ameshkov commented Jun 6, 2016

Yep, #605 is a duplicate, thank you:)

@ameshkov ameshkov assigned nkartyshov and unassigned Revertron Jul 14, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jul 14, 2016

Member

It should different for Trial period and for users who has purchases a license key.

So, for Trial period:

  1. 3 days before trial period is expired.
  2. 1 day before trial period is expired.
  3. Expired

For "premium" users:

  1. 14 days before license is expired
  2. 1 day before license is expired
  3. Expired
Member

ameshkov commented Jul 14, 2016

It should different for Trial period and for users who has purchases a license key.

So, for Trial period:

  1. 3 days before trial period is expired.
  2. 1 day before trial period is expired.
  3. Expired

For "premium" users:

  1. 14 days before license is expired
  2. 1 day before license is expired
  3. Expired
@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jul 14, 2016

Member

@nkartyshov one more note: all these notifications should lead to "Get Premium" activity (instead of the main activity as it does now).

One more clarification: if license is expired or it is a trial period, then it should be "Get Premium" activity.
If license is not yet expired, it should be "Manage License" activity.

Member

ameshkov commented Jul 14, 2016

@nkartyshov one more note: all these notifications should lead to "Get Premium" activity (instead of the main activity as it does now).

One more clarification: if license is expired or it is a trial period, then it should be "Get Premium" activity.
If license is not yet expired, it should be "Manage License" activity.

@nkartyshov

This comment has been minimized.

Show comment
Hide comment
@nkartyshov

nkartyshov Jul 21, 2016

Member

done

Member

nkartyshov commented Jul 21, 2016

done

@nkartyshov nkartyshov closed this Jul 21, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 5, 2016

Contributor

Ever since this landed, I get the notification every day on my tablet that I run in free proxy-mode. I could understand once a week or month, but every day is a little (lot) obnoxious!

Contributor

TPS commented Aug 5, 2016

Ever since this landed, I get the notification every day on my tablet that I run in free proxy-mode. I could understand once a week or month, but every day is a little (lot) obnoxious!

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 8, 2016

Member

@TPS this is really bad. Could you please take a screenshot of that notification?

@Revertron please take a look at the code. What's wrong with it? Could it be that in case of Amazon version we are doing something wrong?

Member

ameshkov commented Aug 8, 2016

@TPS this is really bad. Could you please take a screenshot of that notification?

@Revertron please take a look at the code. What's wrong with it? Could it be that in case of Amazon version we are doing something wrong?

@ameshkov ameshkov reopened this Aug 8, 2016

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Aug 8, 2016

Member

Okay, I see 2 bugs there:

  1. Our DateHelperUtils.getDaysDiff() is rounding up the difference in days.
  2. The expired notification is shown every 12 hours.

What should I do?

Member

Revertron commented Aug 8, 2016

Okay, I see 2 bugs there:

  1. Our DateHelperUtils.getDaysDiff() is rounding up the difference in days.
  2. The expired notification is shown every 12 hours.

What should I do?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 8, 2016

Member
  1. The expired notification is shown every 12 hours.

You mean every 12 hours?

The notifications described in this comment must be shown once:
#606 (comment)

There should be some sort of protection from showing such notification more than once.

Member

ameshkov commented Aug 8, 2016

  1. The expired notification is shown every 12 hours.

You mean every 12 hours?

The notifications described in this comment must be shown once:
#606 (comment)

There should be some sort of protection from showing such notification more than once.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 8, 2016

Contributor

I think (obviously) showing such a nagscreen… err, nag-notification (?) every 12 hours is too often, but it honestly doesn't need to be once ever, either. Tone it down to 1st&15th or 10th&24th of each month (just to split difference between weekly & monthly), & perhaps make the wording more fun/persuasive, & you all will drive premium subscriptions without driving users away.

Bonus: If you put the nag info into an updating internal subscription, you can update it 2× monthly to include info on new features, promotions, &c, to make us want it more. 😉

Contributor

TPS commented Aug 8, 2016

I think (obviously) showing such a nagscreen… err, nag-notification (?) every 12 hours is too often, but it honestly doesn't need to be once ever, either. Tone it down to 1st&15th or 10th&24th of each month (just to split difference between weekly & monthly), & perhaps make the wording more fun/persuasive, & you all will drive premium subscriptions without driving users away.

Bonus: If you put the nag info into an updating internal subscription, you can update it 2× monthly to include info on new features, promotions, &c, to make us want it more. 😉

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 8, 2016

Member

I meant it should be shown one time for each of the key dates, e.g.: 14 days before expiration, 3 days, 1 day and one time after the expiration.

Member

ameshkov commented Aug 8, 2016

I meant it should be shown one time for each of the key dates, e.g.: 14 days before expiration, 3 days, 1 day and one time after the expiration.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Aug 8, 2016

Member

New version is here, you cat test it, @TPS :
adguard-2.7.212rc.zip

Member

Revertron commented Aug 8, 2016

New version is here, you cat test it, @TPS :
adguard-2.7.212rc.zip

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 9, 2016

Contributor

What should I be/not be looking for, precisely? Is it set to notify once & never again, or periodically?

Contributor

TPS commented Aug 9, 2016

What should I be/not be looking for, precisely? Is it set to notify once & never again, or periodically?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 9, 2016

Member

What should I be/not be looking for, precisely? Is it set to notify once & never again, or periodically?

As I understand you should see this notification one time and no more after that.

Member

ameshkov commented Aug 9, 2016

What should I be/not be looking for, precisely? Is it set to notify once & never again, or periodically?

As I understand you should see this notification one time and no more after that.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 9, 2016

Member

@Revertron I wonder how we check on our side that now it is fixed for good (without waiting for a day)?

Member

ameshkov commented Aug 9, 2016

@Revertron I wonder how we check on our side that now it is fixed for good (without waiting for a day)?

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Aug 9, 2016

Member
  1. Make a premium key for 1 day
  2. Activate some device (with fixed rc version) with that key
  3. Build new apk that will increment the date going from server by one day, install it over previous one.
  4. Check license, get notification that license is expired
  5. Make another build that will increment date from server by two-three days - check license again.

Does it sound like a plan?
P.S.: And, of course, we will need to manipulate premium status a bit ;-)

Member

Revertron commented Aug 9, 2016

  1. Make a premium key for 1 day
  2. Activate some device (with fixed rc version) with that key
  3. Build new apk that will increment the date going from server by one day, install it over previous one.
  4. Check license, get notification that license is expired
  5. Make another build that will increment date from server by two-three days - check license again.

Does it sound like a plan?
P.S.: And, of course, we will need to manipulate premium status a bit ;-)

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 10, 2016

Contributor

@Revertron @ameshkov I've installed all ßs from last 36 hours or so: Received "Expired" notification 1×. I'll now wait 12 to 24 hours more, & see whether it repeats.

Contributor

TPS commented Aug 10, 2016

@Revertron @ameshkov I've installed all ßs from last 36 hours or so: Received "Expired" notification 1×. I'll now wait 12 to 24 hours more, & see whether it repeats.

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Aug 10, 2016

Member

id 1373702

"I had to uninstall the adguard from my phone since it started to inform
me daily that premium stuff is no longer available, even tho I never have
had the premium version of the adguard. This happened after moving from
normal release to the beta release."

Member

vozersky commented Aug 10, 2016

id 1373702

"I had to uninstall the adguard from my phone since it started to inform
me daily that premium stuff is no longer available, even tho I never have
had the premium version of the adguard. This happened after moving from
normal release to the beta release."

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 10, 2016

Member

@vozersky the issue is fixed in the latest RC.

Member

ameshkov commented Aug 10, 2016

@vozersky the issue is fixed in the latest RC.

@Eugene-Savenko

This comment has been minimized.

Show comment
Hide comment
@Eugene-Savenko

Eugene-Savenko Aug 10, 2016

Member

Ok, I'll send him another follow up )
upd: не успел.

Member

Eugene-Savenko commented Aug 10, 2016

Ok, I'll send him another follow up )
upd: не успел.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 11, 2016

Contributor

For the record: no more upgrade notifications! Thanks, @AdguardTeam.

Contributor

TPS commented Aug 11, 2016

For the record: no more upgrade notifications! Thanks, @AdguardTeam.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Aug 11, 2016

Member

Okay.

Member

Revertron commented Aug 11, 2016

Okay.

@Revertron Revertron closed this Aug 11, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 12, 2016

Member

@TPS thanks for testing it!

Member

ameshkov commented Aug 12, 2016

@TPS thanks for testing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment