New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of stopping protection on settings change, show a toast message #667

Closed
ameshkov opened this Issue Jul 4, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@ameshkov
Member

ameshkov commented Jul 4, 2016

Stopping protection is rather annoying, so instead of doing it we'd better show a toast message.

Something like that:

You need to stop and restart the protection in order for changes to take effect

TODO: list all settings for which protection restart is needed.

@ameshkov ameshkov added the UI label Jul 4, 2016

@ameshkov ameshkov added this to the 2.7 milestone Jul 4, 2016

@ameshkov ameshkov self-assigned this Jul 4, 2016

@ameshkov ameshkov changed the title from Instead of stopping protection on settings show a toast message to Instead of stopping protection on settings change, show a toast message Jul 13, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jul 14, 2016

Member

Done

Member

ameshkov commented Jul 14, 2016

Done

@ameshkov ameshkov closed this Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment