New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count DNS traffic towards a virtual package "DNS" #668

Closed
ameshkov opened this Issue Jul 5, 2016 · 13 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented Jul 5, 2016

Currently it is counted as "Android OS" which is quite ok. However, I think it would be better to create a virtual package DNS so that user could understand how many DNS requests were blocked when "Filter DNS requests" feature is turned ON.

@ameshkov ameshkov added the Enhancement label Jul 5, 2016

@ameshkov ameshkov added this to the 2.7 milestone Jul 5, 2016

@ameshkov ameshkov self-assigned this Jul 5, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Jul 6, 2016

Contributor

Would/could this also have some use when using pref.vpn.dns? Maybe to show which resolver(s) are being used, how often, or such? Obviously, not really useful to block DNS outright! 😉

Contributor

TPS commented Jul 6, 2016

Would/could this also have some use when using pref.vpn.dns? Maybe to show which resolver(s) are being used, how often, or such? Obviously, not really useful to block DNS outright! 😉

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jul 6, 2016

Member

Obviously, not really useful to block DNS outright

This is not about blocking whole DNS. There is a "Filter DNS requests" feature which allows AG to block requests to ad servers on the dns level. The problem is that there is no place where you can see how many requests were blocked.

Member

ameshkov commented Jul 6, 2016

Obviously, not really useful to block DNS outright

This is not about blocking whole DNS. There is a "Filter DNS requests" feature which allows AG to block requests to ad servers on the dns level. The problem is that there is no place where you can see how many requests were blocked.

@ameshkov ameshkov assigned Revertron and unassigned ameshkov Jul 19, 2016

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Jul 22, 2016

Member

Done.

Member

Revertron commented Jul 22, 2016

Done.

@Revertron Revertron closed this Jul 22, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 26, 2016

Contributor

@AdguardTeam Now that this has been implemented a while, I'm completely confused by the DNS stats I see. For instance, my all-time #s read "↑ 1.3 MB ↓ 1.4 MB Ø 92.9 MB".… Does this make sense in context? I'm using OpenDNS's resolvers under my custom DNS settings.

Contributor

TPS commented Aug 26, 2016

@AdguardTeam Now that this has been implemented a while, I'm completely confused by the DNS stats I see. For instance, my all-time #s read "↑ 1.3 MB ↓ 1.4 MB Ø 92.9 MB".… Does this make sense in context? I'm using OpenDNS's resolvers under my custom DNS settings.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 29, 2016

Member

I guess you also have DNS filtering enabled in AG?

I also suppose the "saved" value does not make any sense indeed. It should be way higher as blocking an ad host once means that ALL requests to this host will be blocked for an hour.

The problem here is that we can't even roughly estimate what will be the real savings.

Member

ameshkov commented Aug 29, 2016

I guess you also have DNS filtering enabled in AG?

I also suppose the "saved" value does not make any sense indeed. It should be way higher as blocking an ad host once means that ALL requests to this host will be blocked for an hour.

The problem here is that we can't even roughly estimate what will be the real savings.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 29, 2016

Contributor

Yes, DNS filtering is active, but not HTTPS filtering.

I don't understand at all why the Ø amount is something like 20× the combined ↑+↓ amount. That means something like 95% of DNS requests are to ad servers?!

Contributor

TPS commented Aug 29, 2016

Yes, DNS filtering is active, but not HTTPS filtering.

I don't understand at all why the Ø amount is something like 20× the combined ↑+↓ amount. That means something like 95% of DNS requests are to ad servers?!

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 29, 2016

Member

Nope, it's just we estimate a usual ad request as 10-30kb, while in case of DNS it is a lot smaller.

Member

ameshkov commented Aug 29, 2016

Nope, it's just we estimate a usual ad request as 10-30kb, while in case of DNS it is a lot smaller.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 29, 2016

Contributor

💡 OIC.… Maybe you all may want to adjust that estimation in this 1 place to get a better idea of what's done here. Better yet, do this 1 stat in terms of request #s, so: "↑17000 ↓15000 Ø 2000" or some such?

Also, it'd be helpful to have lists here re: Top 10 servers blocked, Last 10 servers blocked, &c

Contributor

TPS commented Aug 29, 2016

💡 OIC.… Maybe you all may want to adjust that estimation in this 1 place to get a better idea of what's done here. Better yet, do this 1 stat in terms of request #s, so: "↑17000 ↓15000 Ø 2000" or some such?

Also, it'd be helpful to have lists here re: Top 10 servers blocked, Last 10 servers blocked, &c

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 29, 2016

Member

This anyway does not solve the precision issue.

As I've said, a host blocked once on the DNS level is equivalent to multiple ad requests blocked with the usual approach .

Member

ameshkov commented Aug 29, 2016

This anyway does not solve the precision issue.

As I've said, a host blocked once on the DNS level is equivalent to multiple ad requests blocked with the usual approach .

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 29, 2016

Contributor

I meant it's fine to keep counting it the way it is toward the general ad-block count, but, the way it's setup now, it's not clear how many %age DNS requests are blocked.

Contributor

TPS commented Aug 29, 2016

I meant it's fine to keep counting it the way it is toward the general ad-block count, but, the way it's setup now, it's not clear how many %age DNS requests are blocked.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 29, 2016

Member

Why, you can see how many ad requests are blocked if you tap on the DNS app.

Member

ameshkov commented Aug 29, 2016

Why, you can see how many ad requests are blocked if you tap on the DNS app.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 30, 2016

Contributor

I mean, relatively; e.g., right now, it shows 4183 ads blocked per 1 day/month/all time (?), but out of how many total requests? I've no sense of scale with just that #.

Contributor

TPS commented Aug 30, 2016

I mean, relatively; e.g., right now, it shows 4183 ads blocked per 1 day/month/all time (?), but out of how many total requests? I've no sense of scale with just that #.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Sep 6, 2016

Member

I mean, relatively; e.g., right now, it shows 4183 ads blocked per 1 day/month/all time (?), but out of how many total requests? I've no sense of scale with just that #.

I must admin this is a great idea! 4183 is just a number it does not mean much without total requests number.

Member

ameshkov commented Sep 6, 2016

I mean, relatively; e.g., right now, it shows 4183 ads blocked per 1 day/month/all time (?), but out of how many total requests? I've no sense of scale with just that #.

I must admin this is a great idea! 4183 is just a number it does not mean much without total requests number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment