New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to select filters update check period #746

Closed
ameshkov opened this Issue Aug 15, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented Aug 15, 2016

To make it simple let's make just a simple combobox:
Default
1 hour
3 hours
6 hours
12 hours
24 hours
48 hours

@nkartyshov check how FilterServiceImpl.UPDATE_INVALIDATE_PERIOD is used.
Do not allow "too small" values for it. If preference value is lower than 1 hour, fallback to default.

@ameshkov ameshkov added this to the 2.8 milestone Aug 15, 2016

@nkartyshov

This comment has been minimized.

Show comment
Hide comment
@nkartyshov

nkartyshov Oct 31, 2016

Member

done

Member

nkartyshov commented Oct 31, 2016

done

@nkartyshov nkartyshov closed this Oct 31, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 31, 2016

Member

In order for it to work properly we should set the job period to 30 minutes:
https://forum.adguard.com/index.php?threads/filters-update-check-period-not-working-properly.15554/

Member

ameshkov commented Oct 31, 2016

In order for it to work properly we should set the job period to 30 minutes:
https://forum.adguard.com/index.php?threads/filters-update-check-period-not-working-properly.15554/

@ameshkov ameshkov reopened this Oct 31, 2016

@nkartyshov

This comment has been minimized.

Show comment
Hide comment
@nkartyshov

nkartyshov Nov 1, 2016

Member

done

Member

nkartyshov commented Nov 1, 2016

done

@nkartyshov nkartyshov closed this Nov 1, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Nov 11, 2016

Contributor

When this automatic check is done after period elapses, is there a toast (like for manual check) showing result, or is this completely silent? I'd prefer a toast @ least anytime an update succeeds, & maybe even when there isn't any change.

(Just for future reference, #574 (comment) attempted to first request customized interval, IIRC.)

Contributor

TPS commented Nov 11, 2016

When this automatic check is done after period elapses, is there a toast (like for manual check) showing result, or is this completely silent? I'd prefer a toast @ least anytime an update succeeds, & maybe even when there isn't any change.

(Just for future reference, #574 (comment) attempted to first request customized interval, IIRC.)

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Nov 15, 2016

Member

@TPS it is silent, toast on every update check would be just too annoying.

Member

ameshkov commented Nov 15, 2016

@TPS it is silent, toast on every update check would be just too annoying.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Nov 16, 2016

Contributor

Should I open a new issue to request an option for a toast on every successful update? I'd like the option.

Contributor

TPS commented Nov 16, 2016

Should I open a new issue to request an option for a toast on every successful update? I'd like the option.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Nov 16, 2016

Member

Should I open a new issue to request an option for a toast on every successful update? I'd like the option.

Yeah, it should be filed as a separate issue:)

Member

ameshkov commented Nov 16, 2016

Should I open a new issue to request an option for a toast on every successful update? I'd like the option.

Yeah, it should be filed as a separate issue:)

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Dec 24, 2016

Contributor

This period seems not work anymore since last app update or 2 (e.g., "last update" message @ bottom of main screen isn't reflecting update every ➊ hour, as I've configured, though it does show time of last manual update several hours earlier).

Contributor

TPS commented Dec 24, 2016

This period seems not work anymore since last app update or 2 (e.g., "last update" message @ bottom of main screen isn't reflecting update every ➊ hour, as I've configured, though it does show time of last manual update several hours earlier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment