New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HAR writer - make the current file valid #784

Closed
ameshkov opened this Issue Sep 6, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented Sep 6, 2016

It is always necessary to add ]}} to the end of current har file manually.

We can fix HAR writer to have a valid current file, just add these characters for every record (and then overwrite when the next record is added).

Look at HarWriter.writeHarEntry and HarWriter.writeFooter

You can test HAR validity here:
http://www.softwareishard.com/har/viewer/

@ameshkov ameshkov added the Enhancement label Sep 6, 2016

@ameshkov ameshkov added this to the 2.8 milestone Sep 6, 2016

@ameshkov ameshkov self-assigned this Sep 6, 2016

@ameshkov ameshkov assigned nkartyshov and unassigned ameshkov Sep 20, 2016

@nkartyshov

This comment has been minimized.

Show comment
Hide comment
@nkartyshov

nkartyshov Sep 29, 2016

Member

done

Member

nkartyshov commented Sep 29, 2016

done

@nkartyshov nkartyshov closed this Sep 29, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Nov 4, 2016

Member

Now you add extra ]}} to every file

Member

ameshkov commented Nov 4, 2016

Now you add extra ]}} to every file

@ameshkov ameshkov reopened this Nov 4, 2016

@nkartyshov

This comment has been minimized.

Show comment
Hide comment
@nkartyshov

nkartyshov Nov 11, 2016

Member

fixed

Member

nkartyshov commented Nov 11, 2016

fixed

@nkartyshov nkartyshov closed this Nov 11, 2016

@theseanl

This comment has been minimized.

Show comment
Hide comment
@theseanl

theseanl Apr 30, 2017

The issue is still occurring on me with 2.9.70 version.

theseanl commented Apr 30, 2017

The issue is still occurring on me with 2.9.70 version.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 8, 2017

Member

@seanl-adg how come? you should always add these 3 characters?

Can you reproduce it reliably?

Member

ameshkov commented May 8, 2017

@seanl-adg how come? you should always add these 3 characters?

Can you reproduce it reliably?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment