Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count total requests count #785

Closed
ameshkov opened this issue Sep 6, 2016 · 4 comments
Closed

Count total requests count #785

ameshkov opened this issue Sep 6, 2016 · 4 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Sep 6, 2016

We currently count the number of blocked requests. Without total requests count this number does not mean much.

Thanks to @TPS for the idea:
#668 (comment)

@ameshkov ameshkov added the Enhancement label Sep 6, 2016
@ameshkov ameshkov added this to the 3.0 milestone Sep 6, 2016
@ameshkov ameshkov self-assigned this Sep 6, 2016
@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Sep 6, 2016

You're welcome, of course! 😊 This would be better if this is done everyplace any kind of statistics are displayed — i.e., not just main screen for ads, but threats (right now, it seems it counts only blocked threats, not total, like when I "Continue Anyway") & each app individually on the firewall/stats screen, especially that Virtual DNS package, which is what #668 was about, anyway.

Even better if #48 (comment) is accomplished, also.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Sep 9, 2016

Also, for wherever the "Total Bandwidth Saved" stat ends up after #713, it also needs similar context. I suggest something like (Total Bandwidth Saved – AdGuard Bandwidth Consumed [from def updates, &c])/Total Bandwidth Processed.

@ameshkov ameshkov added the P3: Medium label Dec 4, 2017
@admitrevskiy admitrevskiy self-assigned this Aug 15, 2018
@ameshkov ameshkov removed their assignment Aug 27, 2018
@admitrevskiy

This comment has been minimized.

Copy link

@admitrevskiy admitrevskiy commented Aug 31, 2018

Resolved.

Testing instructions:
-Reinstall AG
-Start protection
-Use filtered apps
-Go to Apps Management and select any package

Expected result:
-There is new statistics field with total requests count
-You can sort apps by total requests count in the Apps Management

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Nov 11, 2018

On 3.0.56ƞ's App Management screen, individual app's stats are perfect. Can we get this globally, here & on main AG screen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.