New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce `pref.filtered.ports` low level setting #796

Closed
ameshkov opened this Issue Sep 20, 2016 · 9 comments

Comments

Projects
None yet
4 participants
@ameshkov
Member

ameshkov commented Sep 20, 2016

Currently we filter only ports 80 and 443.

Check the following methods:
FilteringVpnService.setupVpn
ProxyConfigurationServiceImpl.setupTransparentProxy

Instead of hard-coding these two ports we should:

  1. Use a low-level setting named pref.filtered.ports
  2. Default value should be 80,443,3128
@nkartyshov

This comment has been minimized.

Show comment
Hide comment
@nkartyshov

nkartyshov Oct 4, 2016

Member

done

Member

nkartyshov commented Oct 4, 2016

done

@nkartyshov nkartyshov closed this Oct 4, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Oct 5, 2016

Contributor

Just to confirm: this pref is functional for both VPN & proxy?

Also, does the pref handle ranges (e.g.: 80-88)?

Contributor

TPS commented Oct 5, 2016

Just to confirm: this pref is functional for both VPN & proxy?

Also, does the pref handle ranges (e.g.: 80-88)?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 5, 2016

Member

Just to confirm: this pref is functional for both VPN & proxy?

Yep, it does.

Also, does the pref handle ranges (e.g.: 80-88)?

No, you'll have to set a coma separated list of ports.

Member

ameshkov commented Oct 5, 2016

Just to confirm: this pref is functional for both VPN & proxy?

Yep, it does.

Also, does the pref handle ranges (e.g.: 80-88)?

No, you'll have to set a coma separated list of ports.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Oct 6, 2016

Contributor

Especially since it might be likely that port ranges may be necessary, is this possible to implement also, please?

Contributor

TPS commented Oct 6, 2016

Especially since it might be likely that port ranges may be necessary, is this possible to implement also, please?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 6, 2016

Member

@TPS i've filed a separate task for this:
#830

This could be difficult. This task is more about handling standard proxy ports and not websites which use non-standard ports. So implementing it will require additional testing

Member

ameshkov commented Oct 6, 2016

@TPS i've filed a separate task for this:
#830

This could be difficult. This task is more about handling standard proxy ports and not websites which use non-standard ports. So implementing it will require additional testing

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Oct 14, 2016

Contributor

Is there a simple way within Android to tell what apps are using what ports? I know utilities that do so in Windows, but can't seem to find anything comparable for use within Android.

Contributor

TPS commented Oct 14, 2016

Is there a simple way within Android to tell what apps are using what ports? I know utilities that do so in Windows, but can't seem to find anything comparable for use within Android.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 17, 2016

Member

The only easy way is to read Adguad's log and look for "Creating new connection" lines there.

Member

ameshkov commented Oct 17, 2016

The only easy way is to read Adguad's log and look for "Creating new connection" lines there.

@vbagirov

This comment has been minimized.

Show comment
Hide comment
@vbagirov

vbagirov Jan 25, 2017

Member

The problem with pac.proxy is still present (see #751)
reproduced with the latest build

based on forum topic

Member

vbagirov commented Jan 25, 2017

The problem with pac.proxy is still present (see #751)
reproduced with the latest build

based on forum topic

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jan 26, 2017

Member

It works

Member

ameshkov commented Jan 26, 2017

It works

@ameshkov ameshkov closed this Jan 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment