Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `pref.filtered.ports` understand port ranges #830

Closed
ameshkov opened this issue Oct 6, 2016 · 7 comments
Closed

Make `pref.filtered.ports` understand port ranges #830

ameshkov opened this issue Oct 6, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Oct 6, 2016

Syntax could be like:
1-3,4,5,6,80:8080

Source:
#796 (comment)

We should also test that websites using non-standard ports continue to work ok.

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Oct 6, 2016

I think maybe limiting the length of the range (via warning?) to 10 or 100 may be smart.… Else, there'll be 1 of us knuckleheads filing a report stating "AG broke my phone" after inputting 0:65536 or 80:8080. 😜

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Jan 26, 2017

More information about this issue:
#996 (comment)

In case of VPN it's easy.
In case of Proxy+Auto, mind that iptables --dport supports setting port ranges.

@ameshkov ameshkov self-assigned this Feb 7, 2017
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Feb 14, 2017

Done, review ID: AJC-CR-164

@Revertron we need to test it on a rooted device. Could you please do it?

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Feb 15, 2017

@nkartyshov confirmed, that it works ok on a rooted device.

Now we should take some time to check if it causes any issues.

Current setting value:
80,443,1024:65535

@TPS

This comment has been minimized.

Copy link
Contributor

@TPS TPS commented Feb 15, 2017

1024:65535

@ameshkov Are you sure you want to allow such wide port ranges? If so, you might want a complementary pref.UNfiltered.ports option to whitelist some that shouldn't be filtered.…

@Revertron

This comment has been minimized.

Copy link
Member

@Revertron Revertron commented Feb 15, 2017

We could use syntax like this: 80,443,8123,5000:65535,-22,-110 - the minuses will mean exclusion :)

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Feb 15, 2017

@ameshkov Are you sure you want to allow such wide port ranges?

We'll see, that's what beta test is for:)

We could use syntax like this: 80,443,8123,5000:65535,-22,-110 - the minuses will mean exclusion :)

It would be redundant as we can exclude any port using the current syntax by not including it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.