Make `pref.filtered.ports` understand port ranges

[ameshkov]

Syntax could be like:
1-3,4,5,6,80:8080

Source:
#796 (comment)

We should also test that websites using non-standard ports continue to work ok.

[TPS]

I think maybe limiting the length of the range (via warning?) to 10 or 100 may be smart.… Else, there'll be 1 of us knuckleheads filing a report stating "AG broke my phone" after inputting 0:65536 or 80:8080. 😜

[TPS]

I think maybe limiting the length of the range (via warning?) to 10 or 100 may be smart.… Else, there'll be 1 of us knuckleheads filing a report stating "AG broke my phone" after inputting 0:65536 or 80:8080. 😜

[ameshkov]

More information about this issue:
#996 (comment)

In case of VPN it's easy.
In case of Proxy+Auto, mind that iptables --dport supports setting port ranges.

[ameshkov]

More information about this issue:
#996 (comment)

In case of VPN it's easy.
In case of Proxy+Auto, mind that iptables --dport supports setting port ranges.

[ameshkov]

Done, review ID: AJC-CR-164

@Revertron we need to test it on a rooted device. Could you please do it?

[ameshkov]

Done, review ID: AJC-CR-164

@Revertron we need to test it on a rooted device. Could you please do it?

[ameshkov]

@nkartyshov confirmed, that it works ok on a rooted device.

Now we should take some time to check if it causes any issues.

Current setting value:
80,443,1024:65535

[ameshkov]

@nkartyshov confirmed, that it works ok on a rooted device.

Now we should take some time to check if it causes any issues.

Current setting value:
80,443,1024:65535

[TPS]

1024:65535

@ameshkov Are you sure you want to allow such wide port ranges? If so, you might want a complementary pref.UNfiltered.ports option to whitelist some that shouldn't be filtered.…

[TPS]

1024:65535

@ameshkov Are you sure you want to allow such wide port ranges? If so, you might want a complementary pref.UNfiltered.ports option to whitelist some that shouldn't be filtered.…

[Revertron]

We could use syntax like this: 80,443,8123,5000:65535,-22,-110 - the minuses will mean exclusion :)

[Revertron]

We could use syntax like this: 80,443,8123,5000:65535,-22,-110 - the minuses will mean exclusion :)

[ameshkov]

@ameshkov Are you sure you want to allow such wide port ranges?

We'll see, that's what beta test is for:)

We could use syntax like this: 80,443,8123,5000:65535,-22,-110 - the minuses will mean exclusion :)

It would be redundant as we can exclude any port using the current syntax by not including it.

[ameshkov]

@ameshkov Are you sure you want to allow such wide port ranges?

We'll see, that's what beta test is for:)

We could use syntax like this: 80,443,8123,5000:65535,-22,-110 - the minuses will mean exclusion :)

It would be redundant as we can exclude any port using the current syntax by not including it.