Track tasks and feature requests
Join 40 million developers who use GitHub issues to help identify, assign, and keep track of the features and bug fixes your projects need.
Sign up for free See pricing for teams and enterprisesMake `pref.filtered.ports` understand port ranges #830
Comments
This comment has been minimized.
This comment has been minimized.
I think maybe limiting the length of the range (via warning?) to 10 or 100 may be smart.… Else, there'll be 1 of us knuckleheads filing a report stating "AG broke my phone" after inputting |
This comment has been minimized.
This comment has been minimized.
More information about this issue: In case of VPN it's easy. |
This comment has been minimized.
This comment has been minimized.
Done, review ID: AJC-CR-164 @Revertron we need to test it on a rooted device. Could you please do it? |
This comment has been minimized.
This comment has been minimized.
@nkartyshov confirmed, that it works ok on a rooted device. Now we should take some time to check if it causes any issues. Current setting value: |
This comment has been minimized.
This comment has been minimized.
@ameshkov Are you sure you want to allow such wide port ranges? If so, you might want a complementary |
This comment has been minimized.
This comment has been minimized.
We could use syntax like this: |
This comment has been minimized.
This comment has been minimized.
We'll see, that's what beta test is for:)
It would be redundant as we can exclude any port using the current syntax by not including it. |
Syntax could be like:
1-3,4,5,6,80:8080
Source:
#796 (comment)
We should also test that websites using non-standard ports continue to work ok.