New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adguard cannot handle HTTP CONNECT request properly #839

Closed
ameshkov opened this Issue Oct 12, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@ameshkov
Member

ameshkov commented Oct 12, 2016

Steps to reproduce:

  1. Enable HTTPS filtering
  2. Set up a proxy server in the wi-fi settings. Use this proxy: https://forum.adguard.com/index.php?threads/%D0%91%D0%BB%D0%BE%D0%BA%D0%B8%D1%80%D0%BE%D0%B2%D0%BA%D0%B8-%D1%81%D0%B0%D0%B9%D1%82%D0%BE%D0%B2-%D0%A0%D0%9A%D0%9D.15037/
  3. Make sure that the proxy port is listed in pref.filtered.ports (3128,3148)
  4. Go to rutracker.org.
  5. Refresh the page.

Expected result:
Website is filtered ok.

Actual result:
SSL error.

Also I didn't test it with disabled HTTPS filtering. There is a possibility that we have the same issue in this case.

@ameshkov ameshkov added the Bug label Oct 12, 2016

@ameshkov ameshkov added this to the 2.8 milestone Oct 12, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 12, 2016

Member

User's log:
adguard.txt

Member

ameshkov commented Oct 12, 2016

User's log:
adguard.txt

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Oct 14, 2016

Member

Yes, we are not sending CONNECT request to proxy when we are CONNECTing in SslProxyRemoteEndPoint.connect(), I will try to think of something...

Member

Revertron commented Oct 14, 2016

Yes, we are not sending CONNECT request to proxy when we are CONNECTing in SslProxyRemoteEndPoint.connect(), I will try to think of something...

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Oct 19, 2016

Member

Fixed!

Member

Revertron commented Oct 19, 2016

Fixed!

@Revertron Revertron closed this Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment