New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List system packages in the "Tech info" section of "Android OS" details screen #857

Closed
ameshkov opened this Issue Oct 21, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@ameshkov
Member

ameshkov commented Oct 21, 2016

I am talking about "Apps Management" section.

@ameshkov ameshkov added this to the 2.8 milestone Oct 21, 2016

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Oct 24, 2016

Member

Do you mean "packages" from ReservedApps? Or what?

Member

Revertron commented Oct 24, 2016

Do you mean "packages" from ReservedApps? Or what?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 27, 2016

Member

Nah.

I mean we now have a section "Tech info" in the bottom of the "App Details" view.
For "Android OS" we have just "This is a system package" string there (or something like that).

Instead we should list all included packages there.

Member

ameshkov commented Oct 27, 2016

Nah.

I mean we now have a section "Tech info" in the bottom of the "App Details" view.
For "Android OS" we have just "This is a system package" string there (or something like that).

Instead we should list all included packages there.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Oct 28, 2016

Member

But we store there traffic from ReservedApps and Unknown apps (in case that connection is undetermined). We do not store "packages" of system apps or something else.

Member

Revertron commented Oct 28, 2016

But we store there traffic from ReservedApps and Unknown apps (in case that connection is undetermined). We do not store "packages" of system apps or something else.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 28, 2016

Member

Here it is:

        if (!AppRulesManager.getInstance().isTrafficFilteringAndroidOs()) {
            packageInfoList.addAll(PackageUtils.getInstalledReservedPackages(this));
        }

The wording is a bit confusing though, getInstalledReservedPackages returns system apps as well.

Member

ameshkov commented Oct 28, 2016

Here it is:

        if (!AppRulesManager.getInstance().isTrafficFilteringAndroidOs()) {
            packageInfoList.addAll(PackageUtils.getInstalledReservedPackages(this));
        }

The wording is a bit confusing though, getInstalledReservedPackages returns system apps as well.

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron
Member

Revertron commented Oct 31, 2016

device-2016-10-31-090500

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Oct 31, 2016

Member
  1. Package names: --> Included packages:
  2. Add a new line between meta package and included packages
  3. Sort package names
Member

ameshkov commented Oct 31, 2016

  1. Package names: --> Included packages:
  2. Add a new line between meta package and included packages
  3. Sort package names
@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Oct 31, 2016

Member

Done.

Member

Revertron commented Oct 31, 2016

Done.

@Revertron Revertron closed this Oct 31, 2016

@TPS TPS referenced this issue Nov 16, 2016

Open

AdUps SpyWare #908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment