New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior of the `~third-party` modifier #891

Closed
theseanl opened this Issue Nov 5, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@theseanl

theseanl commented Nov 5, 2016

There are many url exception rules in English filter with $~third-party modifier, which I assume is mostly to fix filtering errors on websites of ad or tracking companies.

Requests from mobile apps always matches it because there is no referrer, but they do not need to be excluded for the above purpose. Also such exception rule have a possibility to be exploited by anti-adblock strategies.

We can change the behavior of $~third-party so that it is not applied to requests without referrer, but we have to check that it does not cause unintended behavior of current filters, or we can implement a new modifier $first-party which will be applied only when the referrer is explicitly present.

@theseanl theseanl added the enhancement label Nov 5, 2016

@ameshkov ameshkov added this to the 2.9 milestone Nov 7, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov
Member

ameshkov commented Nov 7, 2016

@ameshkov ameshkov changed the title from Investigate possible behavior change of ~third-party to Change behavior of the `~third-party` modifier Feb 16, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 16, 2017

Member

Makes perfect sense.

Done, review ID: AJC-CR-170

Member

ameshkov commented Feb 16, 2017

Makes perfect sense.

Done, review ID: AJC-CR-170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment