Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall temporary allowance notification is not displayed #966

Closed
vozersky opened this issue Dec 6, 2016 · 10 comments
Closed

Firewall temporary allowance notification is not displayed #966

vozersky opened this issue Dec 6, 2016 · 10 comments
Assignees
Labels
Milestone

Comments

@vozersky
Copy link
Member

@vozersky vozersky commented Dec 6, 2016

Reproduced on Samsung s7

Could be a foreground detection issue.

Here's what we should do

In order to detect if the app is in foreground or not, we should be using the UsageStatsManager: https://developer.android.com/reference/android/app/usage/UsageStatsManager.html

The only question is when should we ask for the necessary permissions. I suggest doing it every time user decides to block network access for some app (or a list of apps via the batch action).

More info

queryEvents can be slow, we have to test it.

https://github.com/ricvalerio/foregroundappchecker
https://medium.com/@quiro91/show-app-usage-with-usagestatsmanager-d47294537dab

@vozersky vozersky added the Bug label Dec 6, 2016
@vozersky vozersky added this to the 2.9 milestone Dec 6, 2016
@ameshkov ameshkov assigned nkartyshov and unassigned Revertron Feb 7, 2017
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 7, 2017

@vozersky can you reproduce it with Nougat?

@vozersky

This comment has been minimized.

Copy link
Member Author

@vozersky vozersky commented Feb 8, 2017

@ameshkov yes, same story with Nougat

@vozersky

This comment has been minimized.

Copy link
Member Author

@vozersky vozersky commented Feb 9, 2017

@ameshkov @Revertron @nkartyshov

Looks like it became a common issue for all devices with Android 7.
Firewall temporary allowance notification doesn't work anymore.

@vozersky vozersky changed the title Firewall temporary allowance notification is not displayed on Samsung devices Firewall temporary allowance notification is not displayed Feb 9, 2017
@nkartyshov

This comment has been minimized.

Copy link
Contributor

@nkartyshov nkartyshov commented Feb 10, 2017

This problem is not solve now. Android 7 restrict access to folder /proc for other processes, but solve this problem help use UsageStatsManager.

Information about UsageStatsManager: https://developer.android.com/reference/android/app/usage/UsageStatsManager.html.

@ameshkov ameshkov modified the milestones: 3.0, 2.9 Feb 12, 2017
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 12, 2017

Delayed to v3.0 as this UsageStatsManager integration will take quite some time, and I'd like v2.9 to be released as soon as possible.

@vozersky

This comment has been minimized.

Copy link
Member Author

@vozersky vozersky commented Jun 29, 2017

more complains about the bug: id 583184

@kbahlyk

This comment has been minimized.

Copy link

@kbahlyk kbahlyk commented Jul 3, 2017

Same issue on Android 7.1.1.
Ticket ID: 1556849

@Wiredframe

This comment has been minimized.

Copy link

@Wiredframe Wiredframe commented Jul 3, 2017

Great to see you're working on fixing this issue. The notification feature was great, hope it'll be back in the future. Good luck.

@Eugene-Savenko

This comment has been minimized.

Copy link
Member

@Eugene-Savenko Eugene-Savenko commented Aug 20, 2017

Here too, MIUI 8.5 on Android 7.0: 1589286

@ameshkov ameshkov modified the milestones: 3.0, 2.11 Feb 9, 2018
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Feb 16, 2018

Done

@ameshkov ameshkov closed this Feb 16, 2018
@vozersky vozersky reopened this Mar 2, 2018
@vozersky vozersky closed this Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.