New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left-sidebar navigation #969

Closed
ameshkov opened this Issue Dec 7, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@ameshkov
Member

ameshkov commented Dec 7, 2016

Can't wait till v3.0, we need it earlier:)

  • No more right-top menu.
  • "Check updates" button -> make it the same as in "Adguard Content Blocker" (right-top corner image button)
  • Menu items just like we're planning for v3.0:
Dashboard ---> rename to "Home" (as it is not yet a dashboard).
Apps Management
-----
Settings
-----
Send feedback
Activate license (or "Manage license")
About
-----
Exit

Icons (48px):
Adguard 2.9 Navigation.zip

Icons (24px):
Adguard 2.9 Navigation (1).zip

@ameshkov ameshkov added the enhancement label Dec 7, 2016

@ameshkov ameshkov added this to the 2.9 milestone Dec 7, 2016

@ameshkov ameshkov added UI and removed enhancement labels Dec 7, 2016

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Jan 16, 2017

Member

Done!

Member

Revertron commented Jan 16, 2017

Done!

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 7, 2017

Member

Not yet, I'll add notes to this task

Member

ameshkov commented Feb 7, 2017

Not yet, I'll add notes to this task

@ameshkov ameshkov reopened this Feb 7, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 7, 2017

Member

Here is a list of activities, where we should get rid of the old action bar menu.

  1. Settings (and subsettings)
  2. FAQ (list)
  3. FAQ (answer)
  4. Apps Management
  5. App details
  6. License status
  7. Send Feedback
  8. About
  9. User filter/Whitelist
Member

ameshkov commented Feb 7, 2017

Here is a list of activities, where we should get rid of the old action bar menu.

  1. Settings (and subsettings)
  2. FAQ (list)
  3. FAQ (answer)
  4. Apps Management
  5. App details
  6. License status
  7. Send Feedback
  8. About
  9. User filter/Whitelist
@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 7, 2017

Member

Apps Management

It should have its own action bar menu.

Menu items

  • Preferences --> Leads to the Firewall settings activity.
  • Clear statistics --> Clears all the traffic statistics.
  • Reset settings ---> Resets settings to default. Please note, that this action is executed asynchronously and leads to the whole apps management section refresh.

Settings

  • Remove "Apps Management" and "Firewall" from the list.

Settings --> General

  • Remove "Clear statistics" from there.

Firewall

  • Change title to "Apps Management" (as it is now actually "Apps Management settings")
  • Remove "Apps Management" item
  • Add "Clear statistics" item
Member

ameshkov commented Feb 7, 2017

Apps Management

It should have its own action bar menu.

Menu items

  • Preferences --> Leads to the Firewall settings activity.
  • Clear statistics --> Clears all the traffic statistics.
  • Reset settings ---> Resets settings to default. Please note, that this action is executed asynchronously and leads to the whole apps management section refresh.

Settings

  • Remove "Apps Management" and "Firewall" from the list.

Settings --> General

  • Remove "Clear statistics" from there.

Firewall

  • Change title to "Apps Management" (as it is now actually "Apps Management settings")
  • Remove "Apps Management" item
  • Add "Clear statistics" item
@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 7, 2017

Member

"License status" is weird, it is visible how it goes through "Subscription status".

There was no such issue in v2.8

Member

ameshkov commented Feb 7, 2017

"License status" is weird, it is visible how it goes through "Subscription status".

There was no such issue in v2.8

@Revertron

This comment has been minimized.

Show comment
Hide comment
@Revertron

Revertron Feb 8, 2017

Member

Done, review - AJC-CR-153

Member

Revertron commented Feb 8, 2017

Done, review - AJC-CR-153

@ameshkov ameshkov closed this Mar 2, 2017

@deLumren

This comment has been minimized.

Show comment
Hide comment
@deLumren

deLumren Mar 29, 2017

In 2.9. "Clear statistics" button is harder to reach than now:
You need to go to Apps Management - top-right corner - Clear Statistics.
WiIl this be changed before going live?

deLumren commented Mar 29, 2017

In 2.9. "Clear statistics" button is harder to reach than now:
You need to go to Apps Management - top-right corner - Clear Statistics.
WiIl this be changed before going live?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Apr 2, 2017

Member

@deLumren nope, why? Context menu is a good for place for this kind of actions.

Member

ameshkov commented Apr 2, 2017

@deLumren nope, why? Context menu is a good for place for this kind of actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment