New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App preview does not work #973

Closed
ameshkov opened this Issue Dec 9, 2016 · 12 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented Dec 9, 2016

Description:
http://forum.xda-developers.com/showpost.php?p=70008707&postcount=1959

As far as App preview messages, that's located under Settings > Google. When adblocking is enabled for Google Play Services, it says there is no internet connection. With adblocking disabled, it works properly and enables the feature for receiving Allo messages without requiring Allo to be installed.

@ameshkov ameshkov added this to the 2.9 milestone Dec 9, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 7, 2017

Member

@vozersky I need you to test it.

Member

ameshkov commented Feb 7, 2017

@vozersky I need you to test it.

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Feb 10, 2017

Member

tested on Samsung s7, nexus 5x and 6p
can't make App preview work for Allo even without Adguard on device at all
(it's all enabled in settings -> google, etc.)

Member

vozersky commented Feb 10, 2017

tested on Samsung s7, nexus 5x and 6p
can't make App preview work for Allo even without Adguard on device at all
(it's all enabled in settings -> google, etc.)

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 12, 2017

Member

Huh, so we can't reproduce it right?

Member

ameshkov commented Feb 12, 2017

Huh, so we can't reproduce it right?

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Feb 13, 2017

Member

Oh, I was able to test app preview now.
You have to unregister your number in Allo completely, not just uninstall .

But it works fine for me, even with HTTPS filtering enabled, So no, unfortunately we can't reproduce such an issue.

Could it be a specific filtering rule problem?

Screenshot:

screenshot_20170213-135222 1

Member

vozersky commented Feb 13, 2017

Oh, I was able to test app preview now.
You have to unregister your number in Allo completely, not just uninstall .

But it works fine for me, even with HTTPS filtering enabled, So no, unfortunately we can't reproduce such an issue.

Could it be a specific filtering rule problem?

Screenshot:

screenshot_20170213-135222 1

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Feb 14, 2017

Member

It was not an Adguard issue, i guess.

Member

vozersky commented Feb 14, 2017

It was not an Adguard issue, i guess.

@vozersky vozersky closed this Feb 14, 2017

@ameshkov ameshkov modified the milestones: 2.10, 2.9 Apr 30, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
Member

ameshkov commented Apr 30, 2017

@ameshkov ameshkov reopened this Apr 30, 2017

@carlylemiii

This comment has been minimized.

Show comment
Hide comment
@carlylemiii

carlylemiii May 30, 2017

Don't know if this is already obvious or helpful in the slightest, but I just want to add that I can access this with Adguard enabled IF I disable HTTPS filtering for Google Play services. Otherwise, it indeed says "No internet connection" for me, as well.

carlylemiii commented May 30, 2017

Don't know if this is already obvious or helpful in the slightest, but I just want to add that I can access this with Adguard enabled IF I disable HTTPS filtering for Google Play services. Otherwise, it indeed says "No internet connection" for me, as well.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jun 12, 2017

Member

@carlylemiii this is important indeed, thank you!

So I reckon you can reproduce this issue? We cannot, so I'd be grateful if you assist us with it.

To find out what's the reason of it, I need to take a look at Adguard's log with "record everything" level:
https://kb.adguard.com/en/android/solving-problems/log

Member

ameshkov commented Jun 12, 2017

@carlylemiii this is important indeed, thank you!

So I reckon you can reproduce this issue? We cannot, so I'd be grateful if you assist us with it.

To find out what's the reason of it, I need to take a look at Adguard's log with "record everything" level:
https://kb.adguard.com/en/android/solving-problems/log

@carlylemiii

This comment has been minimized.

Show comment
Hide comment
@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jun 14, 2017

Member

Found it, thank you very much!

Here's what happens.

GMS establishes a secure connection with instantmessaging-pa.googleapis.com. When HTTPS filtering is disabled, everything is simple -- AG transparently tunnels traffic for this domain.

When it is enabled, AG tries to handle it as if it was regular HTTPS protocol, which is a mistake as it's not. AG tries to read request data, but the thing is that they use some custom protocol and data is actually pushed from the server side.

@carlylemiii could you please try adding instantmessaging-pa.googleapis.com and leave HTTPS filtering enabled for GPS app. Does it help?

Member

ameshkov commented Jun 14, 2017

Found it, thank you very much!

Here's what happens.

GMS establishes a secure connection with instantmessaging-pa.googleapis.com. When HTTPS filtering is disabled, everything is simple -- AG transparently tunnels traffic for this domain.

When it is enabled, AG tries to handle it as if it was regular HTTPS protocol, which is a mistake as it's not. AG tries to read request data, but the thing is that they use some custom protocol and data is actually pushed from the server side.

@carlylemiii could you please try adding instantmessaging-pa.googleapis.com and leave HTTPS filtering enabled for GPS app. Does it help?

@carlylemiii

This comment has been minimized.

Show comment
Hide comment
@carlylemiii

carlylemiii Jun 14, 2017

carlylemiii commented Jun 14, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jun 14, 2017

Member

Resolved, review ID: AFA-CR-29

AG now checks ALPN TLS extension and does not filter HTTPS if the extension is present, but there's no supported application layer protocol found.

Member

ameshkov commented Jun 14, 2017

Resolved, review ID: AFA-CR-29

AG now checks ALPN TLS extension and does not filter HTTPS if the extension is present, but there's no supported application layer protocol found.

@ameshkov ameshkov closed this Jun 14, 2017

@ameshkov ameshkov modified the milestones: 2.9 R2, 2.10 Jun 14, 2017

@ameshkov ameshkov added SSL and removed cannot reproduce labels Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment