Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform the user about closed connection to a website with EV certificate #228

Closed
ghost opened this issue Aug 29, 2017 · 7 comments
Closed

Inform the user about closed connection to a website with EV certificate #228

ghost opened this issue Aug 29, 2017 · 7 comments

Comments

@ghost
Copy link

@ghost ghost commented Aug 29, 2017

edited by @ameshkov
#228 (comment)

Original description:

Steps to reproduce

  1. Visit a website with SSL for the first time in Google Chrome since installing Adguard 1.5.0 beta
  2. Experience an ERR_SSL_VERSION_INTERFERENCE error page for a few seconds
  3. Automatically reloads the page as per usual

Expected behavior

Chrome loads the website normally.

Actual behavior

Chrome displays an ERR_SSL_VERSION_INTERFERENCE error page for a few seconds before refreshing the page automatically and loading the website.

Screenshot: err

Customer ID

1552859

Your environment

  • Environment name and version:
    Chrome Version 61.0.3163.59 (Official Build) beta (64-bit)
    macOS Version 10.13 Beta (17A358a)
    Adguard for Mac Version 1.5.0 beta
    Adguard Chrome Extension Version 2.6.7

  • Any specific potentially conflicting software installed:
    None

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 30, 2017

Do you have "Do not filter EV certificates" enabled?

@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Aug 30, 2017

Yes, this was whilst having that option enabled.

@ameshkov ameshkov added the Question label Aug 30, 2017
ameshkov added a commit to AdguardTeam/HttpsExclusions that referenced this issue Aug 30, 2017
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 30, 2017

Yes, this was whilst having that option enabled.

Then it's intended, unfortunately. It happens for every new website with EV certificate AG encounters for the first time.

You see, the problem is that when AG learns that certificate is EV, it should stop filtering it immediately, and the only way to do it without actually decrypting anything, is to close the connection.

@ameshkov ameshkov closed this Aug 30, 2017
@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Aug 30, 2017

Thanks for the explanation, @ameshkov. Would be there be any way to inform the user when the connection is closed for the first time via a notification to say that this is intentional? Or to provide an explanation underneath the option to know what to expect?

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Aug 30, 2017

Would be there be any way to inform the user when the connection is closed for the first time via a notification to say that this is intentional? Or to provide an explanation underneath the option to know what to expect?

It makes sense, let's transform this issue then.

@ameshkov ameshkov reopened this Aug 30, 2017
@ameshkov ameshkov changed the title ERR_SSL_VERSION_INTERFERENCE (Google Chrome & Adguard 1.5.0 beta) Inform the user about closed connection to a website with EV certificate Aug 30, 2017
@ameshkov ameshkov added this to the 1.5.1 milestone Aug 30, 2017
@ameshkov ameshkov added Enhancement and removed Question labels Aug 30, 2017
@Stillness-2 Stillness-2 closed this Nov 3, 2017
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Nov 7, 2017

First of all, let's add "Exclusions..." setting for websites with EV certificate:
https://uploads.adguard.com/up04_uwv4h_AdGuard_Preferences_-_Network.png

So that user could force filtering of a website even if EV certificate is in use.

Alert text
Title: Connection to example.org has been closed
Text: "example.org" certificate has been added to EV exclusions. Websites with this certificate will not be filtered unless the respective option for EV certificates is disabled.
Button: Filter anyway

Clicking "Filter anyway" adds website to the "Exclusions" list.

@ameshkov ameshkov reopened this Nov 7, 2017
@Stillness-2 Stillness-2 closed this Nov 9, 2017
@Stillness-2

This comment has been minimized.

Copy link
Member

@Stillness-2 Stillness-2 commented Nov 15, 2017

I found some issues... reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.