Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate what cookies were modified in the filtering log #386

Closed
ameshkov opened this issue Dec 4, 2018 · 1 comment
Closed

Indicate what cookies were modified in the filtering log #386

ameshkov opened this issue Dec 4, 2018 · 1 comment
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Dec 4, 2018

Currently, it is not shown in the filtering log

here's how cookie modification looks like in the new browser extension version:

AdguardTeam/AdguardBrowserExtension#961

@Stillness-2

This comment has been minimized.

Copy link
Member

@Stillness-2 Stillness-2 commented Mar 15, 2019

Also we work here on tasks from
AdguardTeam/AdguardForWindows#2427

  1. It reports that HTML elements are removed from jpg, CSS, JS files, that cannot be so: https://uploads.adguard.com/up04_1qrhx_Windows_7_Enterprise_1.png

  1. We should use the same statuses we get from CoreLibs:
  2. Color indication
    • Blocked - red
    • Modified - yellow
    • Whitelisted - green
    • Bypassed - no color
  3. Show the full list of rules applied to the request in the log item details (including whitelist, cookie, csp, whatever).
  4. Additionally, show the stealth mode actions applied (if any)
  5. Exceptions: removed cookies and removed HTML elements should be separate items in the filtering log (just like we do now).
  6. "Size" value should be replaced with ↑3.0 KB ↓15.0 KB. That's important to understand what's the size of uploaded data.
  7. [-] Rule column value:
    • Do not print $$, $cookie, and $stealth rules there;
    • In the case of a single rule, just print it there;
    • In the case of multiple rules applied, print "5 rules";
  8. Add filter column:
    • In the case of a single rule, just print filter name there;
    • In the case of multiple rules applied, leave empty";
    • If no rules were applied, but status is modified:
      • If there are any stealth mode actions applied, print "Stealth mode"
      • If this is a "Document", print "Cosmetic rules"
      • In any other case this might be a bug of CoreLibs:)
  9. Print Connection ID for processed requests as well
@zzebrum zzebrum closed this Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.