Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use Traditional Chinese translations for Web of Trust, AdGuard Assistant and Popup blocker when choosing Traditional Chinese interface in the system preferences of macOS. #503

Closed
ameshkov opened this issue May 26, 2019 · 20 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented May 26, 2019

@zzebrum commented on Tue Nov 13 2018

@lancelot-moon commented on Sat Sep 29 2018

I don't have Mac, but I saw another Taiwanese user shared screenshots about AdGuard for Mac.
It seems that you used wrong language (Simplified Chinese) in Traditional Chinese interface.
The Chinese characters in the screenshot are Simplified Chinese, not Traditional Chinese.

Screenshot:

image


This can be for your reference.
AdguardTeam/AdguardForWindows#2302 (comment)

zh-CN is Simplified Chinese for China.
zh-TW is Traditional Chinese for Taiwan.
On oneskyapp, Traditional Chinese in MISCELLANEOUS were all done long time ago.

Please check that you should use zh-TW for Web of Trust, AdGuard Assistant and Popup blocker when choosing Traditional Chinese interface in the system preferences of macOS.
#318 (comment)

Thanks.


@ameshkov commented on Tue Nov 06 2018

@zebrum could you please check it in the nightly version?


@zzebrum commented on Tue Nov 13 2018

reproduced.


@lancelot-moon commented on Sat May 25 2019

This bug isn't fixed in AG for Mac v2.0.2 Beta.
@ameshkov

  1. May you assign someone to early fix the bug before AG for Mac v2 Release?

AG Assistant is Simplified Chinese (zh-CN) interface while system language is Traditional Chinese (zh-TW).

Screenshots:

image

image


Are you using the latest extensions in AG for Mac v2?
May you really check if Traditional Chinese normally represent for Web of Trust, AG Assistant, AG Extra and Popup blocker while system language is Traditional Chinese (zh-TW)?

  1. How about AG Assistant in AG for Safari?
    The same bug?

  2. Simplified Chinese are outmoded translations in AG Assistant.

Screenshot:

image


You can see WoT isn't correctly shown in the below.
Lack placeholders in Simplified Chinese translations.

Screenshot:

image


This is the correct Traditional Chinese interface of AG Assistant in AG for Windows v7 for your reference.
You can see the placeholder of WoT.

Screenshot:

image


Thanks.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented May 26, 2019

Moved to AG for Mac repo so that I could assign release v2 to it. I'd like this to be fixed asap.

@maximtop we need to test this.

I suppose the issue is caused by different locales naming on Mac and other platforms. It is zh-tw on Win and Android, but it is zh-hans-tw on Mac.

You can use this app to run AdGuard with a different locale: http://www.tj-hd.co.uk/en-gb/languageswitcher/

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 29, 2019

You use a wrong locale in v2.0.3 beta.
No, it's zh-hant-tw, not zh-hans-tw.
Sorry, I didn't early remind you at that time, which is my fault.

http://www.rfc-editor.org/rfc/rfc4646.txt
Language tags are related when they contain a similar sequence of
subtags. For example, if a language tag B contains language tag A as
a prefix, then B is typically "narrower" or "more specific" than A.
Thus, "zh-Hant-TW" is more specific than "zh-Hant".

zh-Hant (Chinese written using the Traditional Chinese script)
zh-Hans (Chinese written using the Simplified Chinese script)

https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
Type: redundant
Tag: zh-Hant-TW
Description: Taiwan Chinese in traditional script

https://www.w3.org/International/articles/bcp47/

Screenshot:

image


In v2.0.3 beta, AG Assistant is still Simplified Chinese.
It should be Traditional Chinese in Traditional Chinese interface.

Screenshot:

image


@ameshkov
Please let @Stillness-2 send me screenshots on telegram before releasing new beta!
Stillness-2, when your system language is Traditional Chinese, please first send the screenshots of AG Assistant, filters and the blocking page to me on telegram.
After I check they're ok, you release next v2.0.4 beta.

@Stillness-2

This comment has been minimized.

Copy link
Member

@Stillness-2 Stillness-2 commented May 29, 2019

@lancelot-moon check latest nightly build please

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 30, 2019

Fixed, thanks.

Screenshots:

image

image

image


@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

@Stillness-2

Why is the issue fixed in nightly but NOT fixed in v2.0.4 Release?

The same wrong things as v2.0.3 beta.
Wrongly use Simplified Chinese in AG Assistant.

@Stillness-2

This comment has been minimized.

Copy link
Member

@Stillness-2 Stillness-2 commented May 31, 2019

螢幕快照 2019-05-31 上午9 37 20
@lancelot-moon Is this traditional?

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

Your screenshots are Traditional Chinese.
But I don't know why the netfriend gets the same wrong things as v2.0.3 beta when he uses v2.0.4 Release.
https://imgur.com/a/0S2TQlt

Strange.

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

The more information:
https://imgur.com/a/JZ7tSNP

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

He said the wrong issues happen in v2.0.4 Release.

But everything is ok in v2.0.4 nightly.

https://imgur.com/a/PEaS6sO

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

He said most apps use zh_TW for Traditional Chinese (Taiwan).

But AdGuard for Mac use zh-Hant.
https://imgur.com/a/21NMIZN

@Stillness-2

This comment has been minimized.

Copy link
Member

@Stillness-2 Stillness-2 commented May 31, 2019

@lancelot-moon Run this utility in the terminal (Terminal.app). And give us what this program will print.
test-locale.zip

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

Test locale:

Screenshot:

image


@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

Do you remember this?
#319 (comment)

I guess the locale of Traditional Chinese (Taiwan) in macOS is zh_TW, not zh-Hant-TW...

zh_TW matches zh_TW but doesn't match zh-Hant-TW.

zh-Hant matches zh-Hant-TW and zh-Hant-HK but doesn't match zh_TW.

BTW, everything is correct in nightly version but is failed in release version.
Strange.

@Stillness-2

This comment has been minimized.

Copy link
Member

@Stillness-2 Stillness-2 commented May 31, 2019

"BTW, everything is correct in nightly version but is failed in release version.
Strange."
nightly and release - the same build. I do not rebuilt app for release, only name changed!
Very strange

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

Try to use zh_TW as the locale of Traditional Chinese (Taiwan) in AG for Mac.

zh_TW matches zh_TW but doesn't match zh-Hant-TW.

zh-Hant matches zh-Hant-TW and zh-Hant-HK but doesn't match zh_TW.

Well, let Hong Kong go. XD
(Traditional Chinese is used in Taiwan and Hong Kong.)

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

Hi, I get some information.

  1. If updating app from old version, it's Traditional Chinese.

  2. If first installing AG v2 nightly and then also installing AG v2 release (overwrite), it's Traditional Chinese.

  3. If cleanly installing AG v2 release (no any AG for Mac installed), filters and AG Assistant are Simplified Chinese, and the blocking page is English.

Can you reproduce?

@Stillness-2

This comment has been minimized.

Copy link
Member

@Stillness-2 Stillness-2 commented May 31, 2019

"If cleanly installing AG v2 release (no any AG for Mac installed), it's Simplified Chinese."
installed using AdGuard installer, which downloaded from adguard.com (pressing "DOWNLOAD")?

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

Uninstall AG for Mac if ever installing it.
Download AG for Mac v2 release installer from GitHub and cleanly install it.

https://github.com/AdguardTeam/AdguardForMac/releases/download/v2.0.4/Adguard-2.0.4.release.dmg

The issue should be reproduced.

@Stillness-2

This comment has been minimized.

Copy link
Member

@Stillness-2 Stillness-2 commented May 31, 2019

@lancelot-moon Thank you. On GitHub was wrong build. :) Check now please.

@lancelot-moon

This comment has been minimized.

Copy link

@lancelot-moon lancelot-moon commented May 31, 2019

Good!
The installer on GitHub is fixed.
You can close the related issues.

Screenshot:

image


Thanks!

@zzebrum zzebrum closed this Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.